fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-03 03:28:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

v3dv: don't submit noop job if there is nothing to wait on or signal

Browse source 
Also, do not unconditionally flag signaling for submits without any
command buffers.

Reviewed-by: Melissa Wen <mwen@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14802>
This commit is contained in:
Iago Toral Quiroga 2022-01-31 13:07:32 +01:00 • committed by Marge Bot
parent 4fa24747b9
commit ce99b1a746
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/broadcom/vulkan/v3dv_queue.c
View file

@ -1176,6 +1176,9 @@ queue_submit_noop_job(struct v3dv_queue *queue,
struct v3dv_submit_info_semaphores *sems_info,
bool do_sem_signal, bool serialize)
{
if (!do_sem_signal && !serialize && !sems_info->wait_sem_count)
return VK_SUCCESS;
/* VkQueue host access is externally synchronized so we don't need to lock
* here for the static variable.
*/
@ -1382,7 +1385,8 @@ queue_submit_cmd_buffer_batch(struct v3dv_queue *queue,
* to do anything special, it should not be a common case anyway.
*/
if (pSubmit->commandBufferCount == 0) {
result = queue_submit_noop_job(queue, &sems_info, true, false);
result = queue_submit_noop_job(queue, &sems_info,
sems_info.signal_sem_count > 0, false);
} else {
const uint32_t last_cmd_buffer_idx = pSubmit->commandBufferCount - 1;
for (uint32_t i = 0; i < pSubmit->commandBufferCount; i++) {