diff --git a/.pick_status.json b/.pick_status.json index e16c42d138c..66e031b3e5d 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -130,7 +130,7 @@ "description": "i915g: fix implicit fallthrough", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "master_sha": null, "because_sha": "4e861ac4a1f1bdbd28f66e3f15eb45aa45a47bad" }, diff --git a/src/gallium/drivers/i915/i915_fpc_optimize.c b/src/gallium/drivers/i915/i915_fpc_optimize.c index 76ef20d84c3..fc71b2824fe 100644 --- a/src/gallium/drivers/i915/i915_fpc_optimize.c +++ b/src/gallium/drivers/i915/i915_fpc_optimize.c @@ -146,10 +146,13 @@ static unsigned mask_for_unswizzled(int num_components) { case 4: mask |= TGSI_WRITEMASK_W; + FALLTHROUGH; case 3: mask |= TGSI_WRITEMASK_Z; + FALLTHROUGH; case 2: mask |= TGSI_WRITEMASK_Y; + FALLTHROUGH; case 1: mask |= TGSI_WRITEMASK_X; } @@ -340,12 +343,15 @@ static void liveness_analysis(struct i915_optimize_context *ctx, case 3: src_reg = ¤t->FullInstruction.Src[2]; liveness_mark_read(ctx, src_reg, i); + FALLTHROUGH; case 2: src_reg = ¤t->FullInstruction.Src[1]; liveness_mark_read(ctx, src_reg, i); + FALLTHROUGH; case 1: src_reg = ¤t->FullInstruction.Src[0]; liveness_mark_read(ctx, src_reg, i); + FALLTHROUGH; case 0: break; default: diff --git a/src/gallium/drivers/i915/i915_state_sampler.c b/src/gallium/drivers/i915/i915_state_sampler.c index 66a5778717a..534bab32cdb 100644 --- a/src/gallium/drivers/i915/i915_state_sampler.c +++ b/src/gallium/drivers/i915/i915_state_sampler.c @@ -286,8 +286,10 @@ ms3_tiling_bits(enum i915_winsys_buffer_tile tiling) switch (tiling) { case I915_TILE_Y: tiling_bits |= MS3_TILE_WALK_Y; + FALLTHROUGH; case I915_TILE_X: tiling_bits |= MS3_TILED_SURFACE; + FALLTHROUGH; case I915_TILE_NONE: break; } diff --git a/src/gallium/drivers/i915/i915_state_static.c b/src/gallium/drivers/i915/i915_state_static.c index 88b418b1ac3..1d8e211c962 100644 --- a/src/gallium/drivers/i915/i915_state_static.c +++ b/src/gallium/drivers/i915/i915_state_static.c @@ -83,8 +83,10 @@ buf_3d_tiling_bits(enum i915_winsys_buffer_tile tiling) switch (tiling) { case I915_TILE_Y: tiling_bits |= BUF_3D_TILE_WALK_Y; + FALLTHROUGH; case I915_TILE_X: tiling_bits |= BUF_3D_TILED_SURFACE; + FALLTHROUGH; case I915_TILE_NONE: break; }