From ce7f58e3331c2747810e7ec50c485cea050c0278 Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Sat, 13 Feb 2021 20:56:43 -0800 Subject: [PATCH] st/xa: Mark default xa_get_pipe_format case unreachable. Fix defect reported by Coverity Scan. Uninitialized scalar variable (UNINIT) uninit_use: Using uninitialized value fdesc. Field fdesc.format is uninitialized. Fixes: 9f2f5b3d7fd ("st/xa: Initial import of the xa state-tracker and the xa-vmwgfx target.") Suggested-by: Adam Jackson Signed-off-by: Vinson Lee Part-of: (cherry picked from commit a8628fb32e13439bd63e9abc0079ca28a4822645) --- .pick_status.json | 2 +- src/gallium/frontends/xa/xa_tracker.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index d6f6914ccaa..8325c9bc32f 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -13,7 +13,7 @@ "description": "st/xa: Mark default xa_get_pipe_format case unreachable.", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "9f2f5b3d7fd70663b98da5d302fcdfd5bc93db05" }, diff --git a/src/gallium/frontends/xa/xa_tracker.c b/src/gallium/frontends/xa/xa_tracker.c index 31162606375..c802a40edb4 100644 --- a/src/gallium/frontends/xa/xa_tracker.c +++ b/src/gallium/frontends/xa/xa_tracker.c @@ -155,7 +155,7 @@ xa_get_pipe_format(struct xa_tracker *xa, enum xa_formats xa_format) fdesc.format = PIPE_FORMAT_L8_UNORM; break; default: - fdesc.xa_format = xa_format_unknown; + unreachable("Unexpected format"); break; } return fdesc;