fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-22 00:08:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

virgl: document potentially failing blit

Browse source 
This blit can fail, but this is not new; in the old version we
didn't even try to blit in this case. So let's just document the
limitation for now, and leave this for another day.

Signed-off-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
This commit is contained in:
Erik Faye-Lund 2019-04-09 14:25:51 +02:00
parent 3fdacf1c39
commit ce1761edab
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/gallium/drivers/virgl/virgl_texture.c
View file

@ -298,6 +298,12 @@ static void virgl_texture_transfer_unmap(struct pipe_context *ctx,
flush_data(ctx, virgl_transfer(trans->resolve_transfer),
&trans->resolve_transfer->box);
/* FINISHME: In case the destination format isn't renderable here, the
* blit here will currently fail. This could for instance happen if the
* mapped resource is of a compressed format, and it's mapped with both
* read and write usage.
*/
virgl_copy_region_with_blit(ctx,
trans->base.resource, trans->base.level,
&transfer->box,