fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-05 19:50:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

util/sparse_free_list: manipulate node pointers using atomic primitives

Browse source 
Probably doesn't fix anything but those should be accessed in an
atomic way just like the head pointer.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: e4f01eca3b ("util: Add a free list structure for use with util_sparse_array")
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4613>
This commit is contained in:
Lionel Landwerlin 2020-04-17 20:42:41 +03:00 • committed by Marge Bot
parent 36d2a0eed6
commit cdc4377591
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/util/sparse_array.c
View file

@ -241,7 +241,7 @@ util_sparse_array_free_list_push(struct util_sparse_array_free_list *fl,
void *last_elem = util_sparse_array_get(fl->arr, items[0]);
uint32_t *last_next = (uint32_t *)((char *)last_elem + fl->next_offset);
for (unsigned i = 1; i < num_items; i++) {
*last_next = items[i];
p_atomic_set(last_next, items[i]);
assert(items[i] != fl->sentinel);
last_elem = util_sparse_array_get(fl->arr, items[i]);
last_next = (uint32_t *)((char *)last_elem + fl->next_offset);
@ -251,7 +251,7 @@ util_sparse_array_free_list_push(struct util_sparse_array_free_list *fl,
old_head = p_atomic_read(&fl->head);
do {
current_head = old_head;
*last_next = current_head; /* Index is the bottom 32 bits */
p_atomic_set(last_next, (uint32_t)current_head); /* Index is the bottom 32 bits */
uint64_t new_head = free_list_head(current_head, items[0]);
old_head = p_atomic_cmpxchg(&fl->head, current_head, new_head);
} while (old_head != current_head);
@ -270,7 +270,7 @@ util_sparse_array_free_list_pop_idx(struct util_sparse_array_free_list *fl)
uint32_t head_idx = current_head; /* Index is the bottom 32 bits */
void *head_elem = util_sparse_array_get(fl->arr, head_idx);
uint32_t *head_next = (uint32_t *)((char *)head_elem + fl->next_offset);
uint64_t new_head = free_list_head(current_head, *head_next);
uint64_t new_head = free_list_head(current_head, p_atomic_read(head_next));
uint64_t old_head = p_atomic_cmpxchg(&fl->head, current_head, new_head);
if (old_head == current_head)
return head_idx;
@ -291,7 +291,7 @@ util_sparse_array_free_list_pop_elem(struct util_sparse_array_free_list *fl)
uint32_t head_idx = current_head; /* Index is the bottom 32 bits */
void *head_elem = util_sparse_array_get(fl->arr, head_idx);
uint32_t *head_next = (uint32_t *)((char *)head_elem + fl->next_offset);
uint64_t new_head = free_list_head(current_head, *head_next);
uint64_t new_head = free_list_head(current_head, p_atomic_read(head_next));
uint64_t old_head = p_atomic_cmpxchg(&fl->head, current_head, new_head);
if (old_head == current_head)
return head_elem;