fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 17:30:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

anv: Allow more single subresource fast-clears with FCV

Browse source 
Format re-interpretation is no longer a problem with texture views. The
clear color address now points to a clear color that is in the expected
format.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31374>
This commit is contained in:
Nanley Chery 2024-09-06 13:13:13 -04:00 • committed by Marge Bot
parent 35f02d8f36
commit cd8e120b97
1 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/intel/vulkan/anv_image.c
View file

@ -3427,16 +3427,17 @@ anv_layout_to_fast_clear_type(const struct intel_device_info * const devinfo,
return ANV_FAST_CLEAR_DEFAULT_VALUE;
}
/* On TGL (< C0), if a block of fragment shader outputs match the
* surface's clear color, the HW may convert them to fast-clears (see
* HSD 1607794140). This can lead to rendering corruptions if not
* handled properly. We restrict the clear color to zero to avoid issues
* that can occur with:
* - Texture view rendering (including blorp_copy calls)
* - Images with multiple levels or array layers
/* On gfx12, the FCV feature may convert a block of fragment shader
* outputs to fast-clears. If this image has multiple subresources,
* restrict the clear color to zero to keep the fast cleared blocks in
* sync.
*/
if (image->planes[plane].aux_usage == ISL_AUX_USAGE_FCV_CCS_E)
if (image->planes[plane].aux_usage == ISL_AUX_USAGE_FCV_CCS_E &&
(image->vk.mip_levels > 1 ||
image->vk.array_layers > 1 ||
image->vk.extent.depth > 1)) {
return ANV_FAST_CLEAR_DEFAULT_VALUE;
}
/* On gfx9, we only load clear colors for attachments and for BLORP
* surfaces. Outside of those surfaces, we can only support the default