From ccced641b5ccbfcf54c1002c5a35640c40b444a5 Mon Sep 17 00:00:00 2001 From: Boris Brezillon Date: Wed, 27 Nov 2024 17:28:22 +0100 Subject: [PATCH] vk/meta: Pass depth/stencil attachments only when a clear is requested If we pass both, and only one of them is cleared, the other aspect might be disturbed if the format contains both aspects. Signed-off-by: Boris Brezillon Reviewed-by: Lars-Ivar Hesselberg Simonsen Part-of: --- src/vulkan/runtime/vk_meta_clear.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vulkan/runtime/vk_meta_clear.c b/src/vulkan/runtime/vk_meta_clear.c index 0afd5e83711..af62e1a2ab7 100644 --- a/src/vulkan/runtime/vk_meta_clear.c +++ b/src/vulkan/runtime/vk_meta_clear.c @@ -494,12 +494,12 @@ clear_image_level_layers(struct vk_command_buffer *cmd, VK_COLOR_COMPONENT_B_BIT | VK_COLOR_COMPONENT_A_BIT; } - if (image->aspects & VK_IMAGE_ASPECT_DEPTH_BIT) { + if (aspects & VK_IMAGE_ASPECT_DEPTH_BIT) { vk_render.pDepthAttachment = &vk_att; meta_render.depth_attachment_format = format; } - if (image->aspects & VK_IMAGE_ASPECT_STENCIL_BIT) { + if (aspects & VK_IMAGE_ASPECT_STENCIL_BIT) { vk_render.pStencilAttachment = &vk_att; meta_render.stencil_attachment_format = format; }