fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 08:50:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pan/va: Remove redundant MOVs from va_lower_split_64bit
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
Details
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Details

Browse source 
To lower 64bit sources we emit a COLLECT -> SPLIT pair to force
allocation into consecutive registers. When the sources for COLLECT
are outputs of the same SPLIT already, we can omit the COLLECT + SPLIT
pair.

Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
Reviewed-by: Aksel Hjerpbakk <aksel.hjerpbakk@arm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37398>
This commit is contained in:
Christoph Pillmayer 2025-09-15 16:40:26 +00:00 • committed by Marge Bot
parent c83fddb9ed
commit cc5c1c65ef
1 changed files with 30 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
src/panfrost/compiler/valhall/va_lower_split_64bit.c
View file

@ -1,5 +1,6 @@
/*
* Copyright (C) 2021 Collabora Ltd.
* Copyright (C) 2025 Arm Ltd.
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
@ -32,7 +33,7 @@
* respected by RA. This could be optimized, but this is deferred for now.
*/
static void
lower_split_src(bi_context *ctx, bi_instr *I, unsigned s)
lower_split_src(bi_context *ctx, bi_instr *I, unsigned s, bi_instr** lut)
{
/* Skip sources that are already split properly */
bi_index offset_fau = I->src[s];
@ -43,6 +44,16 @@ lower_split_src(bi_context *ctx, bi_instr *I, unsigned s)
return;
}
/* Check if the source regs are already coming from a split. */
bi_index* src_a = &I->src[s];
bi_index* src_b = &I->src[s + 1];
if (bi_is_ssa(*src_a) && bi_is_ssa(*src_b)) {
bi_instr* src_ins_a = lut[src_a->value];
bi_instr* src_ins_b = lut[src_b->value];
if (src_ins_a->op == BI_OPCODE_SPLIT_I32 && src_ins_a == src_ins_b)
return;
}
/* Allocate temporary before the instruction */
bi_builder b = bi_init_builder(ctx, bi_before_instr(I));
bi_index vec = bi_temp(ctx);
@ -61,6 +72,21 @@ lower_split_src(bi_context *ctx, bi_instr *I, unsigned s)
void
va_lower_split_64bit(bi_context *ctx)
{
unsigned count = ctx->ssa_alloc;
bi_instr **lut = rzalloc_array(ctx, bi_instr *, count);
if (!lut)
return;
/* Record producers */
bi_foreach_block(ctx, block) {
bi_foreach_instr_in_block(block, I) {
bi_foreach_dest(I, d) {
lut[I->dest[d].value] = I;
}
}
}
bi_foreach_instr_global(ctx, I) {
bi_foreach_src(I, s) {
if (bi_is_null(I->src[s]) || s >= 4)
@ -69,7 +95,9 @@ va_lower_split_64bit(bi_context *ctx)
struct va_src_info info = va_src_info(I->op, s);
if (info.size == VA_SIZE_64)
lower_split_src(ctx, I, s);
lower_split_src(ctx, I, s, lut);
}
}
ralloc_free(lut);
}