From cc2894345f1161fcbb2f9b9150257e0f6b0b303e Mon Sep 17 00:00:00 2001 From: Rhys Perry Date: Tue, 16 Nov 2021 17:33:11 +0000 Subject: [PATCH] aco/spill: use spills_entry instead of spills_exit to kill linear VGPRs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If a predecessor has only spilled constants (no temporaries), spills_exit will be empty. fossil-db (Sienna Cichlid): Totals from 2 (0.00% of 128647) affected shaders: Latency: 139106 -> 139104 (-0.00%) Signed-off-by: Rhys Perry Reviewed-by: Daniel Schürmann Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5633 Cc: mesa-stable Part-of: --- src/amd/compiler/aco_spill.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/compiler/aco_spill.cpp b/src/amd/compiler/aco_spill.cpp index 96f3bb85061..ce1d830920b 100644 --- a/src/amd/compiler/aco_spill.cpp +++ b/src/amd/compiler/aco_spill.cpp @@ -1614,7 +1614,7 @@ assign_spill_slots(spill_ctx& ctx, unsigned spills_to_vgpr) continue; bool can_destroy = true; - for (std::pair pair : ctx.spills_exit[block.linear_preds[0]]) { + for (std::pair pair : ctx.spills_entry[block.index]) { if (ctx.interferences[pair.second].first.type() == RegType::sgpr && slots[pair.second] / ctx.wave_size == i) {