fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-20 13:50:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

panvk: use cs_move_reg32 and lower to cs_add32 if needed
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
Details
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Details

Browse source 
Trivial but still better than cs_add32 workaround on platforms
supporting MOVE_REG32.

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Christoph Pillmayer <christoph.pillmayer@arm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37951>
This commit is contained in:
Yiwei Zhang 2025-10-19 21:27:20 -07:00 • committed by Marge Bot
parent 81692b8168
commit cc1d942727
2 changed files with 15 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/panfrost/genxml/cs_builder.h
View file

@ -1686,6 +1686,19 @@ cs_umin32(struct cs_builder *b, struct cs_index dest, struct cs_index src1,
} }
} }
static inline void
cs_move_reg32(struct cs_builder *b, struct cs_index dest, struct cs_index src)
{
#if PAN_ARCH >= 11
cs_emit(b, MOVE_REG32, I) {
I.destination = cs_dst32(b, dest);
I.source = cs_src32(b, src);
}
#else
cs_add32(b, dest, src, 0);
#endif
}
#if PAN_ARCH >= 11 #if PAN_ARCH >= 11
static inline void static inline void
cs_and32(struct cs_builder *b, struct cs_index dest, struct cs_index src1, cs_and32(struct cs_builder *b, struct cs_index dest, struct cs_index src1,
@ -1751,15 +1764,6 @@ cs_bit_clear32(struct cs_builder *b, struct cs_index dest, struct cs_index src1,
} }
} }
static inline void
cs_move_reg32(struct cs_builder *b, struct cs_index dest, struct cs_index src)
{
cs_emit(b, MOVE_REG32, I) {
I.destination = cs_dst32(b, dest);
I.source = cs_src32(b, src);
}
}
static inline void static inline void
cs_set_state(struct cs_builder *b, enum mali_cs_set_state_type state, cs_set_state(struct cs_builder *b, enum mali_cs_set_state_type state,
struct cs_index src) struct cs_index src)

4
src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c
View file

@ -2630,8 +2630,8 @@ panvk_cmd_draw_indirect(struct panvk_cmd_buffer *cmdbuf,
/* Emulated immediate multiply: we walk the bits in /* Emulated immediate multiply: we walk the bits in
* base_instance, and accumulate (stride << bit_pos) if the bit * base_instance, and accumulate (stride << bit_pos) if the bit
* is present. This is sub-optimal, but it's simple :-). */ * is present. This is sub-optimal, but it's simple :-). */
cs_add32(b, multiplicand, cs_move_reg32(b, multiplicand,
cs_sr_reg32(b, IDVS, INSTANCE_OFFSET), 0); cs_sr_reg32(b, IDVS, INSTANCE_OFFSET));
/* Flush the loads here so that we don't get automatic flushes /* Flush the loads here so that we don't get automatic flushes
* over and over again due to the divergent nature of the if/else * over and over again due to the divergent nature of the if/else