From cbb1e2dcac4bcc84fa66f262f30820eb5da84a3f Mon Sep 17 00:00:00 2001 From: "Juan A. Suarez Romero" Date: Tue, 13 Apr 2021 10:00:14 +0200 Subject: [PATCH] v3dv: fix assertion Ensure subpass_idx has a valid value; we use "-1" as invalid one. Fixes CID#1468096 "Macro compares unsigned to 0 (NO_EFFECT)" Reviewed-by: Iago Toral Quiroga Signed-off-by: Juan A. Suarez Romero Part-of: --- src/broadcom/vulkan/v3dv_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/broadcom/vulkan/v3dv_cmd_buffer.c b/src/broadcom/vulkan/v3dv_cmd_buffer.c index 8f6c1b78004..6cb9de28a37 100644 --- a/src/broadcom/vulkan/v3dv_cmd_buffer.c +++ b/src/broadcom/vulkan/v3dv_cmd_buffer.c @@ -2680,7 +2680,7 @@ static struct v3dv_job * cmd_buffer_subpass_split_for_barrier(struct v3dv_cmd_buffer *cmd_buffer, bool is_bcl_barrier) { - assert(cmd_buffer->state.subpass_idx >= 0); + assert(cmd_buffer->state.subpass_idx != -1); v3dv_cmd_buffer_finish_job(cmd_buffer); struct v3dv_job *job = v3dv_cmd_buffer_subpass_resume(cmd_buffer,