fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-28 05:20:23 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

glsl: Don't allow const on out or inout function parameters

Browse source 
Fixes piglit tests const-inout-parameter.frag and
const-out-parameter.frag.

Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
Cc: "9.2" <mesa-stable@lists.freedesktop.org>
(cherry picked from commit 5894898148)
This commit is contained in:
Ian Romanick 2013-08-08 16:42:37 -07:00
parent 4006fc4656
commit cb8e109492
1 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/glsl/ast_to_hir.cpp
View file

@ -1963,6 +1963,21 @@ apply_type_qualifier_to_variable(const struct ast_type_qualifier *qual,
_mesa_glsl_shader_target_name(state->target));
}
/* Section 6.1.1 (Function Calling Conventions) of the GLSL 1.10 spec says:
*
* "However, the const qualifier cannot be used with out or inout."
*
* The same section of the GLSL 4.40 spec further clarifies this saying:
*
* "The const qualifier cannot be used with out or inout, or a
* compile-time error results."
*/
if (is_parameter && qual->flags.q.constant && qual->flags.q.out) {
_mesa_glsl_error(loc, state,
"`const' may not be applied to `out' or `inout' "
"function parameters");
}
/* If there is no qualifier that changes the mode of the variable, leave
* the setting alone.
*/