fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-23 06:50:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

ac/llvm: move culling replaced registers to abi

Browse source 
For RADV/Radeonsi llvm backend to use correct value after
culling.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17455>
This commit is contained in:
Qiang Yu 2022-07-05 11:25:35 +08:00 • committed by Marge Bot
parent 463c4c55a7
commit ca0b8ed9b3
2 changed files with 22 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
src/amd/llvm/ac_nir_to_llvm.c
View file

@ -56,13 +56,6 @@ struct ac_nir_context {
LLVMValueRef main_function; LLVMValueRef main_function;
LLVMBasicBlockRef continue_block; LLVMBasicBlockRef continue_block;
LLVMBasicBlockRef break_block; LLVMBasicBlockRef break_block;
LLVMValueRef vertex_id_replaced;
LLVMValueRef instance_id_replaced;
LLVMValueRef tes_u_replaced;
LLVMValueRef tes_v_replaced;
LLVMValueRef tes_rel_patch_id_replaced;
LLVMValueRef tes_patch_id_replaced;
}; };
static LLVMValueRef get_sampler_desc_index(struct ac_nir_context *ctx, nir_deref_instr *deref_instr, static LLVMValueRef get_sampler_desc_index(struct ac_nir_context *ctx, nir_deref_instr *deref_instr,
@ -3620,10 +3613,9 @@ static bool visit_intrinsic(struct ac_nir_context *ctx, nir_intrinsic_instr *ins
case nir_intrinsic_load_cull_small_primitives_enabled_amd: case nir_intrinsic_load_cull_small_primitives_enabled_amd:
result = ctx->abi->intrinsic_load(ctx->abi, instr->intrinsic); result = ctx->abi->intrinsic_load(ctx->abi, instr->intrinsic);
break; break;
case nir_intrinsic_load_vertex_id_zero_base: { case nir_intrinsic_load_vertex_id_zero_base:
result = ctx->vertex_id_replaced ? ctx->vertex_id_replaced : ctx->abi->vertex_id; result = ctx->abi->vertex_id_replaced ? ctx->abi->vertex_id_replaced : ctx->abi->vertex_id;
break; break;
}
case nir_intrinsic_load_local_invocation_id: { case nir_intrinsic_load_local_invocation_id: {
LLVMValueRef ids = ac_get_arg(&ctx->ac, ctx->args->local_invocation_ids); LLVMValueRef ids = ac_get_arg(&ctx->ac, ctx->args->local_invocation_ids);
@ -3668,8 +3660,8 @@ static bool visit_intrinsic(struct ac_nir_context *ctx, nir_intrinsic_instr *ins
} else if (ctx->stage == MESA_SHADER_TESS_CTRL) { } else if (ctx->stage == MESA_SHADER_TESS_CTRL) {
result = ac_get_arg(&ctx->ac, ctx->args->tcs_patch_id); result = ac_get_arg(&ctx->ac, ctx->args->tcs_patch_id);
} else if (ctx->stage == MESA_SHADER_TESS_EVAL) { } else if (ctx->stage == MESA_SHADER_TESS_EVAL) {
result = ctx->tes_patch_id_replaced ? ctx->tes_patch_id_replaced result = ctx->abi->tes_patch_id_replaced ?
: ac_get_arg(&ctx->ac, ctx->args->tes_patch_id); ctx->abi->tes_patch_id_replaced : ac_get_arg(&ctx->ac, ctx->args->tes_patch_id);
} else if (ctx->stage == MESA_SHADER_VERTEX) { } else if (ctx->stage == MESA_SHADER_VERTEX) {
if (ctx->args->vs_prim_id.used) if (ctx->args->vs_prim_id.used)
result = ac_get_arg(&ctx->ac, ctx->args->vs_prim_id); /* legacy */ result = ac_get_arg(&ctx->ac, ctx->args->vs_prim_id); /* legacy */
@ -3710,7 +3702,8 @@ static bool visit_intrinsic(struct ac_nir_context *ctx, nir_intrinsic_instr *ins
result = ctx->abi->user_data; result = ctx->abi->user_data;
break; break;
case nir_intrinsic_load_instance_id: case nir_intrinsic_load_instance_id:
result = ctx->instance_id_replaced ? ctx->instance_id_replaced : ctx->abi->instance_id; result = ctx->abi->instance_id_replaced ?
ctx->abi->instance_id_replaced : ctx->abi->instance_id;
break; break;
case nir_intrinsic_load_num_workgroups: case nir_intrinsic_load_num_workgroups:
if (ctx->abi->load_grid_size_from_user_sgpr) { if (ctx->abi->load_grid_size_from_user_sgpr) {
@ -4017,8 +4010,8 @@ static bool visit_intrinsic(struct ac_nir_context *ctx, nir_intrinsic_instr *ins
break; break;
case nir_intrinsic_load_tess_coord: { case nir_intrinsic_load_tess_coord: {
LLVMValueRef coord[] = { LLVMValueRef coord[] = {
ctx->tes_u_replaced ? ctx->tes_u_replaced : ac_get_arg(&ctx->ac, ctx->args->tes_u), ctx->abi->tes_u_replaced ? ctx->abi->tes_u_replaced : ac_get_arg(&ctx->ac, ctx->args->tes_u),
ctx->tes_v_replaced ? ctx->tes_v_replaced : ac_get_arg(&ctx->ac, ctx->args->tes_v), ctx->abi->tes_v_replaced ? ctx->abi->tes_v_replaced : ac_get_arg(&ctx->ac, ctx->args->tes_v),
ctx->ac.f32_0, ctx->ac.f32_0,
}; };
@ -4259,14 +4252,14 @@ static bool visit_intrinsic(struct ac_nir_context *ctx, nir_intrinsic_instr *ins
get_src(ctx, instr->src[1])); get_src(ctx, instr->src[1]));
break; break;
case nir_intrinsic_overwrite_vs_arguments_amd: case nir_intrinsic_overwrite_vs_arguments_amd:
ctx->vertex_id_replaced = get_src(ctx, instr->src[0]); ctx->abi->vertex_id_replaced = get_src(ctx, instr->src[0]);
ctx->instance_id_replaced = get_src(ctx, instr->src[1]); ctx->abi->instance_id_replaced = get_src(ctx, instr->src[1]);
break; break;
case nir_intrinsic_overwrite_tes_arguments_amd: case nir_intrinsic_overwrite_tes_arguments_amd:
ctx->tes_u_replaced = ac_to_float(&ctx->ac, get_src(ctx, instr->src[0])); ctx->abi->tes_u_replaced = ac_to_float(&ctx->ac, get_src(ctx, instr->src[0]));
ctx->tes_v_replaced = ac_to_float(&ctx->ac, get_src(ctx, instr->src[1])); ctx->abi->tes_v_replaced = ac_to_float(&ctx->ac, get_src(ctx, instr->src[1]));
ctx->tes_rel_patch_id_replaced = get_src(ctx, instr->src[2]); ctx->abi->tes_rel_patch_id_replaced = get_src(ctx, instr->src[2]);
ctx->tes_patch_id_replaced = get_src(ctx, instr->src[3]); ctx->abi->tes_patch_id_replaced = get_src(ctx, instr->src[3]);
break; break;
case nir_intrinsic_export_primitive_amd: { case nir_intrinsic_export_primitive_amd: {
struct ac_ngg_prim prim = {0}; struct ac_ngg_prim prim = {0};

8
src/amd/llvm/ac_shader_abi.h
View file

@ -49,6 +49,14 @@ struct ac_shader_abi {
LLVMValueRef color0, color1; LLVMValueRef color0, color1;
LLVMValueRef user_data; LLVMValueRef user_data;
/* replaced registers when culling enabled */
LLVMValueRef vertex_id_replaced;
LLVMValueRef instance_id_replaced;
LLVMValueRef tes_u_replaced;
LLVMValueRef tes_v_replaced;
LLVMValueRef tes_rel_patch_id_replaced;
LLVMValueRef tes_patch_id_replaced;
/* Varying -> attribute number mapping. Also NIR-only */ /* Varying -> attribute number mapping. Also NIR-only */
unsigned fs_input_attr_indices[MAX_VARYING]; unsigned fs_input_attr_indices[MAX_VARYING];