fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 00:10:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

ir3/lower_pcopy: Fix bug with "illegal" copies and swaps

Browse source 
If the source and destination were within the same full register, like
hr90.x and hr90.y (which both map to r45.x), then we'd perform the
swap/copy with the wrong register. This broke
dEQP-VK.ssbo.phys.layout.random.16bit.scalar.35 once BDA is enabled.

Fixes: 0ffcb19b9d ("ir3: Rewrite register allocation")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13818>
This commit is contained in:
Connor Abbott 2021-11-16 15:20:52 +01:00 • committed by Marge Bot
parent 65da866ad9
commit c98adc56f4
1 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/freedreno/ir3/ir3_lower_parallelcopy.c
View file

@ -109,11 +109,18 @@ do_swap(struct ir3_compiler *compiler, struct ir3_instruction *instr,
.flags = entry->flags & ~IR3_REG_HALF,
});
/* If src and dst are within the same full register, then swapping src
* with tmp above will also move dst to tmp. Account for that here.
*/
unsigned dst =
(entry->src.reg & ~1u) == (entry->dst & ~1u) ?
tmp + (entry->dst & 1u) : entry->dst;
/* Do the original swap with src replaced with tmp */
do_swap(compiler, instr,
&(struct copy_entry){
.src = {.reg = tmp + (entry->src.reg & 1)},
.dst = entry->dst,
.dst = dst,
.flags = entry->flags,
});
@ -192,9 +199,16 @@ do_copy(struct ir3_compiler *compiler, struct ir3_instruction *instr,
.flags = entry->flags & ~IR3_REG_HALF,
});
/* Similar to in do_swap(), account for src being swapped with tmp if
* src and dst are in the same register.
*/
struct copy_src src = entry->src;
if (!src.flags && (src.reg & ~1u) == (entry->dst & ~1u))
src.reg = tmp + (src.reg & 1u);
do_copy(compiler, instr,
&(struct copy_entry){
.src = entry->src,
.src = src,
.dst = tmp + (entry->dst & 1),
.flags = entry->flags,
});