From c96f7a079f0154a64ae9bed84da93316043da15f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Ol=C5=A1=C3=A1k?= Date: Thu, 6 Feb 2025 05:08:09 -0500 Subject: [PATCH] winsys/amdgpu: don't use 32-bit address space for IBs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We run out of the 32-bit address space and then we crash. Reviewed-by: Timur Kristóf Part-of: --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.cpp | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.cpp b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.cpp index beb16ca63be..642384c0597 100644 --- a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.cpp +++ b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.cpp @@ -707,20 +707,13 @@ static bool amdgpu_ib_new_buffer(struct amdgpu_winsys *aws, unsigned flags = RADEON_FLAG_NO_INTERPROCESS_SHARING | RADEON_FLAG_GL2_BYPASS; - if (acs->ip_type == AMD_IP_GFX || - acs->ip_type == AMD_IP_COMPUTE || - acs->ip_type == AMD_IP_SDMA) { - /* Avoids hangs with "rendercheck -t cacomposite -f a8r8g8b8" via glamor - * on Navi 14 - */ - flags |= RADEON_FLAG_32BIT; - } - pb = amdgpu_bo_create(aws, buffer_size, aws->info.gart_page_size, domain, (radeon_bo_flag)flags); - if (!pb) + if (!pb) { + fprintf(stderr, "amdgpu: failed to create IB buffer: size=%u\n", buffer_size); return false; + } mapped = (uint8_t*)amdgpu_bo_map(&aws->dummy_sws.base, pb, NULL, PIPE_MAP_WRITE); if (!mapped) {