From c96c12311478a2b15b016ebedfeaa5a65309f74a Mon Sep 17 00:00:00 2001 From: Lars-Ivar Hesselberg Simonsen Date: Thu, 30 Jan 2025 13:23:50 +0100 Subject: [PATCH] panvk: Set missing shader_modifies_coverage flag The shader_modifies_coverage-flag is currently not set for PanVK. This might lead to issues down the line, so ensure it's set correctly. Fixes: 5544d39f442 ("panvk: Add a CSF backend for panvk_queue/cmd_buffer") Reviewed-by: Boris Brezillon Reviewed-by: Benjamin Lee Part-of: (cherry picked from commit 375116a3a02ae044e1933c5fec673c31451855e3) --- .pick_status.json | 2 +- src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.pick_status.json b/.pick_status.json index 4b9910c6499..78f197a8557 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -1174,7 +1174,7 @@ "description": "panvk: Set missing shader_modifies_coverage flag", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "5544d39f4420da88c53aaf8dd48d86ac92bd0eaa", "notes": null diff --git a/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c b/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c index 6838b4b7773..30d452dc23c 100644 --- a/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c +++ b/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c @@ -1528,6 +1528,10 @@ prepare_dcd(struct panvk_cmd_buffer *cmdbuf) cfg.zs_update_operation = earlyzs.update; cfg.evaluate_per_sample = fs->info.fs.sample_shading && (dyns->ms.rasterization_samples > 1); + + cfg.shader_modifies_coverage = fs->info.fs.writes_coverage || + fs->info.fs.can_discard || + alpha_to_coverage; } else { cfg.allow_forward_pixel_to_kill = true; cfg.allow_forward_pixel_to_be_killed = true;