From c89241211103d95f07eb0d66226c12bb28b146cc Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Sat, 8 May 2021 17:23:52 -0700 Subject: [PATCH] nvc0/ir: Initialize CodeEmitterGK110 member progType in constructor. Fix defect reported by Coverity Scan. Uninitialized scalar field (UNINIT_CTOR) uninit_member: Non-static class member progType is not initialized in this constructor nor in any functions that it calls. Signed-off-by: Vinson Lee Reviewed-by: Ilia Mirkin Reviewed-by: Karol Herbst Part-of: --- .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp index 02d0e3d6adb..46354a2bd71 100644 --- a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp @@ -29,14 +29,12 @@ namespace nv50_ir { class CodeEmitterGK110 : public CodeEmitter { public: - CodeEmitterGK110(const TargetNVC0 *); + CodeEmitterGK110(const TargetNVC0 *, Program::Type); virtual bool emitInstruction(Instruction *); virtual uint32_t getMinEncodingSize(const Instruction *) const; virtual void prepareEmission(Function *); - inline void setProgramType(Program::Type pType) { progType = pType; } - private: const TargetNVC0 *targNVC0; @@ -2793,9 +2791,10 @@ CodeEmitterGK110::prepareEmission(Function *func) calculateSchedDataNVC0(targ, func); } -CodeEmitterGK110::CodeEmitterGK110(const TargetNVC0 *target) +CodeEmitterGK110::CodeEmitterGK110(const TargetNVC0 *target, Program::Type type) : CodeEmitter(target), targNVC0(target), + progType(type), writeIssueDelays(target->hasSWSched) { code = NULL; @@ -2806,8 +2805,7 @@ CodeEmitterGK110::CodeEmitterGK110(const TargetNVC0 *target) CodeEmitter * TargetNVC0::createCodeEmitterGK110(Program::Type type) { - CodeEmitterGK110 *emit = new CodeEmitterGK110(this); - emit->setProgramType(type); + CodeEmitterGK110 *emit = new CodeEmitterGK110(this, type); return emit; }