fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-21 18:00:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

ac/surface: enable thick tiling for 3D textures for better perf on gfx6-8

Browse source 
This increases performance 2.5x for Viewperf/Energy on Tonga.
The value of thick_tiling is also fixed.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28846>
This commit is contained in:
Marek Olšák 2024-04-15 04:44:29 -04:00 • committed by Marge Bot
parent 33f642aa09
commit c87ce78d10
1 changed files with 30 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
src/amd/common/ac_surface.c
View file

@ -813,13 +813,9 @@ static int gfx6_compute_level(ADDR_HANDLE addrlib, const struct ac_surf_config *
case ADDR_TM_PRT_TILED_THIN1:
surf_level->mode = RADEON_SURF_MODE_1D;
break;
case ADDR_TM_2D_TILED_THIN1:
case ADDR_TM_PRT_2D_TILED_THIN1:
case ADDR_TM_PRT_TILED_THICK:
default:
surf_level->mode = RADEON_SURF_MODE_2D;
break;
default:
assert(0);
}
if (is_stencil)
@ -1168,6 +1164,8 @@ static int gfx6_compute_surface(ADDR_HANDLE addrlib, const struct radeon_info *i
case RADEON_SURF_MODE_1D:
if (surf->flags & RADEON_SURF_PRT)
AddrSurfInfoIn.tileMode = ADDR_TM_PRT_TILED_THIN1;
else if (config->is_3d)
AddrSurfInfoIn.tileMode = ADDR_TM_1D_TILED_THICK;
else
AddrSurfInfoIn.tileMode = ADDR_TM_1D_TILED_THIN1;
break;
@ -1178,8 +1176,17 @@ static int gfx6_compute_surface(ADDR_HANDLE addrlib, const struct radeon_info *i
} else {
AddrSurfInfoIn.tileMode = ADDR_TM_PRT_2D_TILED_THIN1;
}
} else
} else {
if (config->is_3d) {
/* GFX6 doesn't have 3D_TILED_XTHICK. */
if (info->gfx_level >= GFX7)
AddrSurfInfoIn.tileMode = ADDR_TM_3D_TILED_XTHICK;
else
AddrSurfInfoIn.tileMode = ADDR_TM_2D_TILED_XTHICK;
} else {
AddrSurfInfoIn.tileMode = ADDR_TM_2D_TILED_THIN1;
}
}
break;
default:
assert(0);
@ -1219,7 +1226,7 @@ static int gfx6_compute_surface(ADDR_HANDLE addrlib, const struct radeon_info *i
/* Only degrade the tile mode for space if TC-compatible HTILE hasn't been
* requested, because TC-compatible HTILE requires 2D tiling.
*/
AddrSurfInfoIn.flags.opt4Space = !AddrSurfInfoIn.flags.tcCompatible &&
AddrSurfInfoIn.flags.opt4Space = !AddrSurfInfoIn.flags.tcCompatible && !config->is_3d &&
!AddrSurfInfoIn.flags.fmask && config->info.samples <= 1 &&
!(surf->flags & RADEON_SURF_FORCE_SWIZZLE_MODE);
@ -1506,7 +1513,21 @@ static int gfx6_compute_surface(ADDR_HANDLE addrlib, const struct radeon_info *i
surf->is_displayable = surf->is_linear || surf->micro_tile_mode == RADEON_MICRO_MODE_DISPLAY ||
surf->micro_tile_mode == RADEON_MICRO_MODE_RENDER;
surf->thick_tiling = AddrSurfInfoOut.blockSlices > 1;
surf->thick_tiling = AddrSurfInfoOut.tileMode == ADDR_TM_1D_TILED_THICK ||
AddrSurfInfoOut.tileMode == ADDR_TM_2D_TILED_THICK ||
AddrSurfInfoOut.tileMode == ADDR_TM_2B_TILED_THICK ||
AddrSurfInfoOut.tileMode == ADDR_TM_3D_TILED_THICK ||
AddrSurfInfoOut.tileMode == ADDR_TM_3B_TILED_THICK ||
AddrSurfInfoOut.tileMode == ADDR_TM_2D_TILED_XTHICK ||
AddrSurfInfoOut.tileMode == ADDR_TM_3D_TILED_XTHICK ||
AddrSurfInfoOut.tileMode == ADDR_TM_PRT_TILED_THICK ||
AddrSurfInfoOut.tileMode == ADDR_TM_PRT_2D_TILED_THICK ||
AddrSurfInfoOut.tileMode == ADDR_TM_PRT_3D_TILED_THICK ||
/* Not thick per se, but these also benefit from the 3D access pattern
* due to pipe rotation between slices.
*/
AddrSurfInfoOut.tileMode == ADDR_TM_3D_TILED_THIN1 ||
AddrSurfInfoOut.tileMode == ADDR_TM_PRT_3D_TILED_THIN1;
/* The rotated micro tile mode doesn't work if both CMASK and RB+ are
* used at the same time. This case is not currently expected to occur