From c83b3de729e3a94637f5c4abde7d19f75702fc8c Mon Sep 17 00:00:00 2001 From: Chia-I Wu Date: Tue, 3 Dec 2024 13:28:34 -0800 Subject: [PATCH] panvk/csf: fix SIMULTANEOUS_USE gpu faults tracing_ctx is always non-NULL in issue_fragment_jobs. Check tracing_ctx->enabled instead. This fixes GPU faults when the desc ringbuf wraps. Fixes: bd49fa68b04 ("panvk/csf: Use event-based CS tracing") Signed-off-by: Chia-I Wu Reviewed-by: Boris Brezillon Part-of: --- src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c b/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c index 9696db30dbc..a8b5eb4a601 100644 --- a/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c +++ b/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c @@ -2339,7 +2339,7 @@ issue_fragment_jobs(struct panvk_cmd_buffer *cmdbuf) /* Update the ring buffer position. */ if (free_render_descs) { cs_render_desc_ringbuf_move_ptr(b, calc_render_descs_size(cmdbuf), - !tracing_ctx); + !tracing_ctx->enabled); } /* Update the frag seqno. */