From c7a8200dcde591c7db55c21e7d4607afeb85d67b Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Fri, 24 Jan 2025 12:47:00 -0500 Subject: [PATCH] hk: don't allocate zero sink Signed-off-by: Alyssa Rosenzweig Part-of: --- src/asahi/vulkan/hk_device.c | 8 -------- src/asahi/vulkan/hk_device.h | 2 +- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/src/asahi/vulkan/hk_device.c b/src/asahi/vulkan/hk_device.c index 444f12565cc..3f99f766629 100644 --- a/src/asahi/vulkan/hk_device.c +++ b/src/asahi/vulkan/hk_device.c @@ -103,14 +103,6 @@ hk_upload_rodata(struct hk_device *dev) dev->rodata.geometry_state = dev->rodata.bo->va->addr + offs; offs += sizeof(struct agx_geometry_state); - /* For null readonly buffers, we need to allocate 16 bytes of zeroes for - * robustness2 semantics on read. - */ - offs = align(offs, 16); - dev->rodata.zero_sink = dev->rodata.bo->va->addr + offs; - memset(map + offs, 0, 16); - offs += 16; - /* For null storage descriptors, we need to reserve 16 bytes to catch writes. * No particular content is required; we cannot get robustness2 semantics * without more work. diff --git a/src/asahi/vulkan/hk_device.h b/src/asahi/vulkan/hk_device.h index 1faf4709f8d..80f10f817cc 100644 --- a/src/asahi/vulkan/hk_device.h +++ b/src/asahi/vulkan/hk_device.h @@ -84,7 +84,7 @@ struct hk_device { struct { struct agx_bo *bo; struct agx_usc_uniform_packed image_heap; - uint64_t null_sink, zero_sink; + uint64_t null_sink; uint64_t geometry_state; } rodata;