fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 00:28:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

etnaviv: Fix memory leak in etna_vertex_elements_state_create.

Browse source 
Fix defect reported by Coverity Scan.

Resource leak (RESOURCE_LEAK)
leaked_storage: Variable cs going out of scope leaks the storage it points to.

Fixes: c9e8b49b88 ("etnaviv: gallium driver for Vivante GPUs")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9034>
(cherry picked from commit a7a7d25e5b)
This commit is contained in:
Vinson Lee 2021-02-13 20:34:39 -08:00 • committed by Dylan Baker
parent eeb7cb93d2
commit c6140fb09d
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -832,7 +832,7 @@
"description": "etnaviv: Fix memory leak in etna_vertex_elements_state_create.",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"master_sha": null,
"because_sha": "c9e8b49b885242d84ba031dacef5aa4a5ac1e5b6"
},

1
src/gallium/drivers/etnaviv/etnaviv_state.c
View file

@ -518,6 +518,7 @@ etna_vertex_elements_state_create(struct pipe_context *pctx,
if (num_elements > screen->specs.vertex_max_elements) {
BUG("number of elements (%u) exceeds chip maximum (%u)", num_elements,
screen->specs.vertex_max_elements);
FREE(cs);
return NULL;
}