From c5e413533f461cffb98150c9d91908ea1911c589 Mon Sep 17 00:00:00 2001 From: Eric Engestrom Date: Sat, 16 May 2026 19:48:27 +0200 Subject: [PATCH] etnaviv: initialize value before calling etna_gpu_get_param(), in case it fails We could add an error check instead, but we actually need `features` to be fully initialized and we'd be setting it to `0` in the else, so let's just initialize `val = 0` and not have to care whether etna_gpu_get_param() succeeds. Fixes: 358e1f10c5263d4bacd7 ("etnaviv: drm: Initialize etna_core_info based on kernel features") Part-of: --- src/etnaviv/drm/etnaviv_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/etnaviv/drm/etnaviv_gpu.c b/src/etnaviv/drm/etnaviv_gpu.c index 2be96327455..33cb32320ca 100644 --- a/src/etnaviv/drm/etnaviv_gpu.c +++ b/src/etnaviv/drm/etnaviv_gpu.c @@ -77,7 +77,7 @@ query_features_from_kernel(struct etna_gpu *gpu) STATIC_ASSERT(ETNA_GPU_FEATURES_12 == 0xf); for (unsigned i = ETNA_GPU_FEATURES_0; i <= ETNA_GPU_FEATURES_12; i++) { - uint64_t val; + uint64_t val = 0; etna_gpu_get_param(gpu, i, &val); features[i - ETNA_GPU_FEATURES_0] = val;