fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-06 07:18:17 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

spirv: Drop the SubgroupUniformControlFlow check

Browse source 
It's just a vtn_fail_if() and there's no actual cap for it.  It's not
really gaining us much to have the check.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Iván Briano <ivan.briano@intel.com>
Acked-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28905>
This commit is contained in:
Faith Ekstrand 2024-04-25 10:18:47 -05:00 • committed by Marge Bot
parent 9ae61a152d
commit c1eaa03904
6 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/amd/vulkan/radv_shader.c
View file

@ -403,7 +403,6 @@ radv_shader_spirv_to_nir(struct radv_device *device, const struct radv_shader_st
.subgroup_quad = true,
.subgroup_rotate = true,
.subgroup_shuffle = true,
.subgroup_uniform_control_flow = true,
.subgroup_vote = true,
.tessellation = true,
.transform_feedback = true,

1
src/compiler/shader_info.h
View file

@ -115,7 +115,6 @@ struct spirv_supported_capabilities {
bool subgroup_quad;
bool subgroup_rotate;
bool subgroup_shuffle;
bool subgroup_uniform_control_flow;
bool subgroup_vote;
bool tessellation;
bool transform_feedback;

4
src/compiler/spirv/spirv_to_nir.c
View file

@ -5555,9 +5555,7 @@ vtn_handle_execution_mode(struct vtn_builder *b, struct vtn_value *entry_point,
break;
case SpvExecutionModeSubgroupUniformControlFlowKHR:
/* There's no corresponding SPIR-V capability, so check here. */
vtn_fail_if(!b->options->caps.subgroup_uniform_control_flow,
"SpvExecutionModeSubgroupUniformControlFlowKHR not supported.");
/* Nothing to do here */
break;
case SpvExecutionModeEarlyAndLateFragmentTestsAMD:

1
src/intel/vulkan/anv_pipeline.c
View file

@ -194,7 +194,6 @@ anv_shader_stage_to_nir(struct anv_device *device,
.subgroup_dispatch = true,
.subgroup_quad = true,
.subgroup_rotate = true,
.subgroup_uniform_control_flow = true,
.subgroup_shuffle = true,
.subgroup_vote = true,
.tessellation = true,

1
src/intel/vulkan_hasvk/anv_pipeline.c
View file

@ -97,7 +97,6 @@ anv_shader_stage_to_nir(struct anv_device *device,
.subgroup_ballot = true,
.subgroup_dispatch = true,
.subgroup_quad = true,
.subgroup_uniform_control_flow = true,
.subgroup_shuffle = true,
.subgroup_vote = true,
.tessellation = true,

1
src/nouveau/vulkan/nvk_shader.c
View file

@ -158,7 +158,6 @@ nvk_get_spirv_options(struct vk_physical_device *vk_pdev,
.subgroup_quad = true,
.subgroup_rotate = true,
.subgroup_shuffle = true,
.subgroup_uniform_control_flow = true,
.subgroup_vote = true,
.tessellation = true,
.transform_feedback = true,