From c11fe3647f165d71853cc5f7a8798a8b0670b021 Mon Sep 17 00:00:00 2001 From: Jason Ekstrand Date: Fri, 13 May 2022 17:01:06 -0500 Subject: [PATCH] anv: Drop alpha_to_coverage from the NULL FS optimization Starting with Ivy Bridge, we implement alpha-to-coverage by writting gl_SampleMask with a pattern based on alpha. This will show up in wm_prog_data::uses_omask so we don't need to look at the key. Fixes: 36ee2fd61c8f ("anv: Implement the basic form of VK_EXT_transform_feedback") Reviewed-by: Lionel Landwerlin Part-of: (cherry picked from commit 9fe6caf4e707bad36c60262b5f28407309f922c7) --- .pick_status.json | 2 +- src/intel/vulkan/anv_pipeline.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 85a29c93272..c59919d7edd 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -1420,7 +1420,7 @@ "description": "anv: Drop alpha_to_coverage from the NULL FS optimization", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "because_sha": "36ee2fd61c8f943be1d1e2b0354f7a121ffef28f" }, { diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c index 2ffb4fc32a9..7c4bb052a43 100644 --- a/src/intel/vulkan/anv_pipeline.c +++ b/src/intel/vulkan/anv_pipeline.c @@ -1356,7 +1356,6 @@ anv_pipeline_compile_fs(const struct brw_compiler *compiler, if (fs_stage->key.wm.color_outputs_valid == 0 && !fs_stage->prog_data.wm.has_side_effects && !fs_stage->prog_data.wm.uses_omask && - !fs_stage->key.wm.alpha_to_coverage && !fs_stage->prog_data.wm.uses_kill && fs_stage->prog_data.wm.computed_depth_mode == BRW_PSCDEPTH_OFF && !fs_stage->prog_data.wm.computed_stencil) {