diff --git a/.pick_status.json b/.pick_status.json index 077a804d09b..201269a9367 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -301,7 +301,7 @@ "description": "zink: use undefined layout for first scanout obj transition", "nominated": false, "nomination_type": null, - "resolution": 4, + "resolution": 1, "master_sha": null, "because_sha": null }, diff --git a/src/gallium/drivers/zink/zink_context.c b/src/gallium/drivers/zink/zink_context.c index eeec8028c50..30c75172cf2 100644 --- a/src/gallium/drivers/zink/zink_context.c +++ b/src/gallium/drivers/zink/zink_context.c @@ -1771,7 +1771,7 @@ copy_scanout(struct zink_context *ctx, struct zink_resource *res) NULL, 0, VK_ACCESS_TRANSFER_WRITE_BIT, - VK_IMAGE_LAYOUT_PRESENT_SRC_KHR, + res->scanout_obj_init ? VK_IMAGE_LAYOUT_PRESENT_SRC_KHR : VK_IMAGE_LAYOUT_UNDEFINED, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, VK_QUEUE_FAMILY_IGNORED, VK_QUEUE_FAMILY_IGNORED, @@ -1804,6 +1804,8 @@ copy_scanout(struct zink_context *ctx, struct zink_resource *res) 0, NULL, 1, &imb ); + /* separate flag to avoid annoying validation errors for new scanout objs */ + res->scanout_obj_init = true; } static void diff --git a/src/gallium/drivers/zink/zink_resource.h b/src/gallium/drivers/zink/zink_resource.h index 1bf959916ef..c298c8fe3d2 100644 --- a/src/gallium/drivers/zink/zink_resource.h +++ b/src/gallium/drivers/zink/zink_resource.h @@ -89,6 +89,7 @@ struct zink_resource { struct zink_resource_object *obj; struct zink_resource_object *scanout_obj; //TODO: remove for wsi + bool scanout_obj_init; union { struct util_range valid_buffer_range; struct {