From c0a9b0f8d6b5dcd46784249e635b2527fa146335 Mon Sep 17 00:00:00 2001 From: Valentine Burley Date: Thu, 20 Jun 2024 20:31:38 +0000 Subject: [PATCH] tu: Use the common version of vkGetBufferMemoryRequirements2 Additionally simplify the code by inlining the logic from tu_get_buffer_memory_requirements directly into tu_GetDeviceBufferMemoryRequirements. Signed-off-by: Valentine Burley Part-of: --- src/freedreno/vulkan/tu_device.cc | 33 ++++++++----------------------- 1 file changed, 8 insertions(+), 25 deletions(-) diff --git a/src/freedreno/vulkan/tu_device.cc b/src/freedreno/vulkan/tu_device.cc index cad91511e1b..5c3b6d7a47f 100644 --- a/src/freedreno/vulkan/tu_device.cc +++ b/src/freedreno/vulkan/tu_device.cc @@ -2948,10 +2948,15 @@ tu_UnmapMemory2KHR(VkDevice _device, const VkMemoryUnmapInfoKHR *pMemoryUnmapInf return tu_bo_unmap(device, mem->bo, pMemoryUnmapInfo->flags & VK_MEMORY_UNMAP_RESERVE_BIT_EXT); } -static void -tu_get_buffer_memory_requirements(struct tu_device *dev, uint64_t size, - VkMemoryRequirements2 *pMemoryRequirements) +VKAPI_ATTR void VKAPI_CALL +tu_GetDeviceBufferMemoryRequirements( + VkDevice _device, + const VkDeviceBufferMemoryRequirements *pInfo, + VkMemoryRequirements2 *pMemoryRequirements) { + VK_FROM_HANDLE(tu_device, device, _device); + + uint64_t size = pInfo->pCreateInfo->size; pMemoryRequirements->memoryRequirements = (VkMemoryRequirements) { .size = MAX2(align64(size, 64), size), .alignment = 64, @@ -2973,28 +2978,6 @@ tu_get_buffer_memory_requirements(struct tu_device *dev, uint64_t size, } } -VKAPI_ATTR void VKAPI_CALL -tu_GetBufferMemoryRequirements2( - VkDevice _device, - const VkBufferMemoryRequirementsInfo2 *pInfo, - VkMemoryRequirements2 *pMemoryRequirements) -{ - VK_FROM_HANDLE(tu_device, device, _device); - VK_FROM_HANDLE(tu_buffer, buffer, pInfo->buffer); - - tu_get_buffer_memory_requirements(device, buffer->vk.size, pMemoryRequirements); -} - -VKAPI_ATTR void VKAPI_CALL -tu_GetDeviceBufferMemoryRequirements( - VkDevice _device, - const VkDeviceBufferMemoryRequirements *pInfo, - VkMemoryRequirements2 *pMemoryRequirements) -{ - VK_FROM_HANDLE(tu_device, device, _device); - tu_get_buffer_memory_requirements(device, pInfo->pCreateInfo->size, pMemoryRequirements); -} - VKAPI_ATTR void VKAPI_CALL tu_GetDeviceMemoryCommitment(VkDevice device, VkDeviceMemory memory,