fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-20 07:20:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

pvr: split framebuffer attachments allocation and setup

Browse source 
Signed-off-by: Luigi Santivetti <luigi.santivetti@imgtec.com>
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38744>
This commit is contained in:
Luigi Santivetti 2025-09-18 12:13:28 +01:00 • committed by Marge Bot
parent bdfc24031b
commit c0526a6880
1 changed files with 41 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

54
src/imagination/vulkan/pvr_cmd_buffer.c
View file

@ -3038,32 +3038,37 @@ void pvr_CmdPushConstants2KHR(VkCommandBuffer commandBuffer,
}
}
static VkResult pvr_cmd_buffer_attachments_setup(
static inline void
pvr_cmd_buffer_attachments_free(struct pvr_cmd_buffer *cmd_buffer)
{
struct pvr_cmd_buffer_state *state = &cmd_buffer->state;
vk_free(&cmd_buffer->vk.pool->alloc, state->render_pass_info.attachments);
state->render_pass_info.attachment_count = 0;
state->render_pass_info.attachments = NULL;
}
static VkResult pvr_cmd_buffer_attachments_alloc(
struct pvr_cmd_buffer *cmd_buffer,
const struct pvr_render_pass *pass,
const struct pvr_framebuffer *framebuffer,
const VkRenderPassBeginInfo *pRenderPassBeginInfo)
uint32_t attachment_count)
{
struct pvr_cmd_buffer_state *state = &cmd_buffer->state;
struct pvr_render_pass_info *info = &state->render_pass_info;
const VkRenderPassAttachmentBeginInfo *pImageless =
vk_find_struct_const(pRenderPassBeginInfo->pNext,
RENDER_PASS_ATTACHMENT_BEGIN_INFO);
if (!pImageless)
assert(pass->attachment_count == framebuffer->attachment_count);
/* Free any previously allocated attachments. */
vk_free(&cmd_buffer->vk.pool->alloc, state->render_pass_info.attachments);
if (pass->attachment_count == 0) {
state->render_pass_info.attachment_count = attachment_count;
if (attachment_count == 0) {
info->attachments = NULL;
return VK_SUCCESS;
}
const size_t size = attachment_count * sizeof(*info->attachments);
info->attachments =
vk_zalloc(&cmd_buffer->vk.pool->alloc,
pass->attachment_count * sizeof(*info->attachments),
size,
8,
VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
if (!info->attachments) {
@ -3071,6 +3076,29 @@ static VkResult pvr_cmd_buffer_attachments_setup(
VK_ERROR_OUT_OF_HOST_MEMORY);
}
return VK_SUCCESS;
}
static VkResult pvr_cmd_buffer_attachments_setup(
struct pvr_cmd_buffer *cmd_buffer,
const struct pvr_render_pass *pass,
const struct pvr_framebuffer *framebuffer,
const VkRenderPassBeginInfo *pRenderPassBeginInfo)
{
const VkRenderPassAttachmentBeginInfo *pImageless =
vk_find_struct_const(pRenderPassBeginInfo->pNext,
RENDER_PASS_ATTACHMENT_BEGIN_INFO);
struct pvr_render_pass_info *info = &cmd_buffer->state.render_pass_info;
VkResult result;
if (!pImageless)
assert(pass->attachment_count == framebuffer->attachment_count);
result = pvr_cmd_buffer_attachments_alloc(cmd_buffer, pass->attachment_count);
if (result != VK_SUCCESS)
return result;
for (uint32_t i = 0; i < pass->attachment_count; i++) {
if (pImageless && pImageless->attachmentCount) {
assert(pImageless->attachmentCount == pass->attachment_count);
@ -3081,7 +3109,7 @@ static VkResult pvr_cmd_buffer_attachments_setup(
}
}
return VK_SUCCESS;
return result;
}
static inline VkResult pvr_render_targets_datasets_create(