fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-01 18:58:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

gbm/dri: Fix leaking bo memory on failure path

Browse source 
In gbm_dri_bo_create, when modifiers are requested but not supported, do
not return NULL immediately, but first go to cleanup section to free
already allocated buffer object.

Fixes: cb9ae4273d ("dri: add loader_dri_create_image helper")
Signed-off-by: Heinrich Fink <hfink@snap.com>
Reviewed-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Simon Ser <contact@emersion.fr>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11844>
This commit is contained in:
Heinrich Fink 2021-07-13 11:12:56 +02:00 • committed by Marge Bot
parent 7eb7ed8cde
commit bff3ac0b26
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/gbm/backends/dri/gbm_dri.c
View file

@ -1196,7 +1196,7 @@ gbm_dri_bo_create(struct gbm_device *gbm,
if (modifiers && (dri->image->base.version < 14 ||
!dri->image->createImageWithModifiers)) {
errno = ENOSYS;
return NULL;
goto failed;
}
bo->image = loader_dri_create_image(dri->screen, dri->image, width, height,