From bfb092b955516d5ff0d1cfb73de80fed30cec6c3 Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Sat, 3 Jun 2023 16:32:44 -0700 Subject: [PATCH] nv50: Fix memory leak in error path Fix defect reported by Coverity Scan. Resource leak (RESOURCE_LEAK) leaked_storage: Variable memobj going out of scope leaks the storage it points to. Fixes: a1571333804 ("nvc0/nv50: support and enable EXT_memory_object*") Signed-off-by: Vinson Lee Reviewed-by: Karol Herbst Part-of: --- src/gallium/drivers/nouveau/nv50/nv50_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_resource.c b/src/gallium/drivers/nouveau/nv50/nv50_resource.c index 6e215be55a5..2e2961c88a8 100644 --- a/src/gallium/drivers/nouveau/nv50/nv50_resource.c +++ b/src/gallium/drivers/nouveau/nv50/nv50_resource.c @@ -109,7 +109,7 @@ nv50_memobj_create_from_handle(struct pipe_screen *screen, memobj->bo = nouveau_screen_bo_from_handle(screen, handle, &memobj->stride); if (memobj->bo == NULL) { - FREE(memobj->bo); + FREE(memobj); return NULL; } memobj->handle = handle;