fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-06-09 23:08:18 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

amd/llvm: fix LLVM asserts for signed integer constants

Browse source 
After LLVM APInt's refactor, stricter checks for
integer signedness are imposed. If a sign extended
uint64_t is passed to LLVMConstInt(...) producing
a value much larger than uintNmax for N < 64,
then LLVM complains.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41822>
This commit is contained in:
Ganesh Belgur Ramachandra 2026-06-05 17:34:24 +05:30 • committed by Marge Bot
parent 7e7f6e79ec
commit bf3333156e
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/amd/llvm/ac_llvm_build.c
View file

@ -1822,7 +1822,7 @@ LLVMValueRef ac_build_cvt_pk_i16(struct ac_llvm_context *ctx, LLVMValueRef args[
assert(bits == 8 || bits == 10 || bits == 16);
LLVMValueRef max_rgb = LLVMConstInt(ctx->i32, bits == 8 ? 127 : bits == 10 ? 511 : 32767, 0);
LLVMValueRef min_rgb = LLVMConstInt(ctx->i32, bits == 8 ? -128 : bits == 10 ? -512 : -32768, 0);
LLVMValueRef min_rgb = LLVMConstInt(ctx->i32, bits == 8 ? -128 : bits == 10 ? -512 : -32768, 1);
LLVMValueRef max_alpha = bits != 10 ? max_rgb : ctx->i32_1;
LLVMValueRef min_alpha = bits != 10 ? min_rgb : LLVMConstInt(ctx->i32, -2, 0);
@ -2212,7 +2212,7 @@ LLVMValueRef ac_find_lsb(struct ac_llvm_context *ctx, LLVMTypeRef dst_type, LLVM
/* TODO: We need an intrinsic to skip this conditional. */
/* Check for zero: */
return LLVMBuildSelect(ctx->builder, LLVMBuildICmp(ctx->builder, LLVMIntEQ, src0, zero, ""),
LLVMConstInt(ctx->i32, -1, 0), lsb, "");
LLVMConstInt(ctx->i32, -1, 1), lsb, "");
}
static struct ac_llvm_flow *get_current_flow(struct ac_llvm_context *ctx)
@ -2791,11 +2791,11 @@ static LLVMValueRef get_reduction_identity(struct ac_llvm_context *ctx, nir_op o
case nir_op_umin:
return LLVMConstInt(ctx->i8, UINT8_MAX, 0);
case nir_op_imax:
return LLVMConstInt(ctx->i8, INT8_MIN, 0);
return LLVMConstInt(ctx->i8, INT8_MIN, 1);
case nir_op_umax:
return ctx->i8_0;
case nir_op_iand:
return LLVMConstInt(ctx->i8, -1, 0);
return LLVMConstInt(ctx->i8, -1, 1);
case nir_op_ior:
return ctx->i8_0;
case nir_op_ixor:
@ -2820,13 +2820,13 @@ static LLVMValueRef get_reduction_identity(struct ac_llvm_context *ctx, nir_op o
case nir_op_fmin:
return LLVMConstReal(ctx->f16, INFINITY);
case nir_op_imax:
return LLVMConstInt(ctx->i16, INT16_MIN, 0);
return LLVMConstInt(ctx->i16, INT16_MIN, 1);
case nir_op_umax:
return ctx->i16_0;
case nir_op_fmax:
return LLVMConstReal(ctx->f16, -INFINITY);
case nir_op_iand:
return LLVMConstInt(ctx->i16, -1, 0);
return LLVMConstInt(ctx->i16, -1, 1);
case nir_op_ior:
return ctx->i16_0;
case nir_op_ixor:
@ -2851,13 +2851,13 @@ static LLVMValueRef get_reduction_identity(struct ac_llvm_context *ctx, nir_op o
case nir_op_fmin:
return LLVMConstReal(ctx->f32, INFINITY);
case nir_op_imax:
return LLVMConstInt(ctx->i32, INT32_MIN, 0);
return LLVMConstInt(ctx->i32, INT32_MIN, 1);
case nir_op_umax:
return ctx->i32_0;
case nir_op_fmax:
return LLVMConstReal(ctx->f32, -INFINITY);
case nir_op_iand:
return LLVMConstInt(ctx->i32, -1, 0);
return LLVMConstInt(ctx->i32, -1, 1);
case nir_op_ior:
return ctx->i32_0;
case nir_op_ixor: