fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-09 08:58:02 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

asahi,agx: Fix stack buffer overflow in agx_link_varyings_vs_fs

Browse source 
Discovered while running dEQP-EGL under address sanitizer.

Fixes: f3877f56ba ("asahi,agx: Rewrite varying linking")
Signed-off-by: Janne Grunau <j@jannau.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24635>
(cherry picked from commit 3f8894b0f7)
This commit is contained in:
Janne Grunau 2023-07-29 19:12:09 +02:00 • committed by Eric Engestrom
parent b69ef88827
commit bf2ec0fc51
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -2146,7 +2146,7 @@
"description": "asahi,agx: Fix stack buffer overflow in agx_link_varyings_vs_fs",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "f3877f56ba7915ee6bc6866c0f4dc21881a3f5fb"
},

4
src/gallium/drivers/asahi/agx_state.c
View file

@ -1367,8 +1367,8 @@ agx_link_varyings_vs_fs(struct agx_pool *pool, struct agx_varyings_vs *vs,
/* I don't understand why the data structures are repeated thrice */
for (unsigned i = 0; i < 3; ++i) {
memcpy(((uint8_t *)ptr.cpu) + (i * linkage_size),
((uint8_t *)tmp) + (i * linkage_size), linkage_size);
memcpy(((uint8_t *)ptr.cpu) + (i * linkage_size), (uint8_t *)tmp,
linkage_size);
}
return ptr.gpu;