draw: add nir info gathering and building support

Reviewed-by: Roland Scheidegger <sroland@vmware.com>
This commit is contained in:
Dave Airlie 2019-09-05 15:47:19 +10:00
parent 44a6b0107b
commit bf12bc2dd7
5 changed files with 63 additions and 26 deletions

View file

@ -32,6 +32,7 @@
#include "util/u_prim.h" #include "util/u_prim.h"
#include "tgsi/tgsi_parse.h" #include "tgsi/tgsi_parse.h"
#include "nir/nir_to_tgsi_info.h"
#include "draw_fs.h" #include "draw_fs.h"
#include "draw_private.h" #include "draw_private.h"
@ -47,7 +48,10 @@ draw_create_fragment_shader(struct draw_context *draw,
dfs = CALLOC_STRUCT(draw_fragment_shader); dfs = CALLOC_STRUCT(draw_fragment_shader);
if (dfs) { if (dfs) {
dfs->base = *shader; dfs->base = *shader;
tgsi_scan_shader(shader->tokens, &dfs->info); if (shader->type == PIPE_SHADER_IR_TGSI)
tgsi_scan_shader(shader->tokens, &dfs->info);
else
nir_tgsi_scan_shader(shader->ir.nir, &dfs->info, false);
} }
return dfs; return dfs;

View file

@ -35,7 +35,7 @@
#include "tgsi/tgsi_parse.h" #include "tgsi/tgsi_parse.h"
#include "tgsi/tgsi_exec.h" #include "tgsi/tgsi_exec.h"
#include "nir/nir_to_tgsi_info.h"
#include "pipe/p_shader_tokens.h" #include "pipe/p_shader_tokens.h"
#include "util/u_math.h" #include "util/u_math.h"
@ -793,13 +793,17 @@ draw_create_geometry_shader(struct draw_context *draw,
gs->draw = draw; gs->draw = draw;
gs->state = *state; gs->state = *state;
gs->state.tokens = tgsi_dup_tokens(state->tokens);
if (!gs->state.tokens) {
FREE(gs);
return NULL;
}
tgsi_scan_shader(state->tokens, &gs->info); if (state->type == PIPE_SHADER_IR_TGSI) {
gs->state.tokens = tgsi_dup_tokens(state->tokens);
if (!gs->state.tokens) {
FREE(gs);
return NULL;
}
tgsi_scan_shader(state->tokens, &gs->info);
} else
nir_tgsi_scan_shader(state->ir.nir, &gs->info, false);
/* setup the defaults */ /* setup the defaults */
gs->max_out_prims = 0; gs->max_out_prims = 0;

View file

@ -43,6 +43,7 @@
#include "gallivm/lp_bld_flow.h" #include "gallivm/lp_bld_flow.h"
#include "gallivm/lp_bld_debug.h" #include "gallivm/lp_bld_debug.h"
#include "gallivm/lp_bld_tgsi.h" #include "gallivm/lp_bld_tgsi.h"
#include "gallivm/lp_bld_nir.h"
#include "gallivm/lp_bld_printf.h" #include "gallivm/lp_bld_printf.h"
#include "gallivm/lp_bld_intr.h" #include "gallivm/lp_bld_intr.h"
#include "gallivm/lp_bld_init.h" #include "gallivm/lp_bld_init.h"
@ -646,7 +647,10 @@ draw_llvm_create_variant(struct draw_llvm *llvm,
memcpy(&variant->key, key, shader->variant_key_size); memcpy(&variant->key, key, shader->variant_key_size);
if (gallivm_debug & (GALLIVM_DEBUG_TGSI | GALLIVM_DEBUG_IR)) { if (gallivm_debug & (GALLIVM_DEBUG_TGSI | GALLIVM_DEBUG_IR)) {
tgsi_dump(llvm->draw->vs.vertex_shader->state.tokens, 0); if (llvm->draw->vs.vertex_shader->state.type == PIPE_SHADER_IR_TGSI)
tgsi_dump(llvm->draw->vs.vertex_shader->state.tokens, 0);
else
nir_print_shader(llvm->draw->vs.vertex_shader->state.ir.nir, stderr);
draw_llvm_dump_variant_key(&variant->key); draw_llvm_dump_variant_key(&variant->key);
} }
@ -712,10 +716,17 @@ generate_vs(struct draw_llvm_variant *variant,
params.ssbo_sizes_ptr = num_ssbos_ptr; params.ssbo_sizes_ptr = num_ssbos_ptr;
params.image = draw_image; params.image = draw_image;
lp_build_tgsi_soa(variant->gallivm, if (llvm->draw->vs.vertex_shader->state.ir.nir &&
tokens, llvm->draw->vs.vertex_shader->state.type == PIPE_SHADER_IR_NIR)
&params, lp_build_nir_soa(variant->gallivm,
outputs); llvm->draw->vs.vertex_shader->state.ir.nir,
&params,
outputs);
else
lp_build_tgsi_soa(variant->gallivm,
tokens,
&params,
outputs);
{ {
LLVMValueRef out; LLVMValueRef out;
@ -2495,7 +2506,10 @@ draw_gs_llvm_generate(struct draw_llvm *llvm,
} }
if (gallivm_debug & (GALLIVM_DEBUG_TGSI | GALLIVM_DEBUG_IR)) { if (gallivm_debug & (GALLIVM_DEBUG_TGSI | GALLIVM_DEBUG_IR)) {
tgsi_dump(tokens, 0); if (llvm->draw->gs.geometry_shader->state.type == PIPE_SHADER_IR_TGSI)
tgsi_dump(tokens, 0);
else
nir_print_shader(llvm->draw->gs.geometry_shader->state.ir.nir, stderr);
draw_gs_llvm_dump_variant_key(&variant->key); draw_gs_llvm_dump_variant_key(&variant->key);
} }
@ -2515,10 +2529,16 @@ draw_gs_llvm_generate(struct draw_llvm *llvm,
params.ssbo_sizes_ptr = num_ssbos_ptr; params.ssbo_sizes_ptr = num_ssbos_ptr;
params.image = image; params.image = image;
lp_build_tgsi_soa(variant->gallivm, if (llvm->draw->gs.geometry_shader->state.type == PIPE_SHADER_IR_TGSI)
tokens, lp_build_tgsi_soa(variant->gallivm,
&params, tokens,
outputs); &params,
outputs);
else
lp_build_nir_soa(variant->gallivm,
llvm->draw->gs.geometry_shader->state.ir.nir,
&params,
outputs);
sampler->destroy(sampler); sampler->destroy(sampler);
image->destroy(image); image->destroy(image);

View file

@ -230,6 +230,7 @@ draw_create_vs_exec(struct draw_context *draw,
tgsi_scan_shader(state->tokens, &vs->base.info); tgsi_scan_shader(state->tokens, &vs->base.info);
vs->base.state.type = state->type;
vs->base.state.stream_output = state->stream_output; vs->base.state.stream_output = state->stream_output;
vs->base.draw = draw; vs->base.draw = draw;
vs->base.prepare = vs_exec_prepare; vs->base.prepare = vs_exec_prepare;

View file

@ -37,7 +37,7 @@
#include "tgsi/tgsi_parse.h" #include "tgsi/tgsi_parse.h"
#include "tgsi/tgsi_scan.h" #include "tgsi/tgsi_scan.h"
#include "nir/nir_to_tgsi_info.h"
static void static void
vs_llvm_prepare(struct draw_vertex_shader *shader, vs_llvm_prepare(struct draw_vertex_shader *shader,
struct draw_context *draw) struct draw_context *draw)
@ -90,14 +90,20 @@ draw_create_vs_llvm(struct draw_context *draw,
if (!vs) if (!vs)
return NULL; return NULL;
/* we make a private copy of the tokens */ /* due to some bugs in the feedback state tracker we have to check
vs->base.state.tokens = tgsi_dup_tokens(state->tokens); for ir.nir & PIPE_SHADER_IR_NIR here. */
if (!vs->base.state.tokens) { if (state->ir.nir && state->type == PIPE_SHADER_IR_NIR)
FREE(vs); nir_tgsi_scan_shader(state->ir.nir, &vs->base.info, false);
return NULL; else {
} /* we make a private copy of the tokens */
vs->base.state.tokens = tgsi_dup_tokens(state->tokens);
if (!vs->base.state.tokens) {
FREE(vs);
return NULL;
}
tgsi_scan_shader(state->tokens, &vs->base.info); tgsi_scan_shader(state->tokens, &vs->base.info);
}
vs->variant_key_size = vs->variant_key_size =
draw_llvm_variant_key_size( draw_llvm_variant_key_size(
@ -106,6 +112,8 @@ draw_create_vs_llvm(struct draw_context *draw,
vs->base.info.file_max[TGSI_FILE_SAMPLER_VIEW]+1), vs->base.info.file_max[TGSI_FILE_SAMPLER_VIEW]+1),
vs->base.info.file_max[TGSI_FILE_IMAGE]+1); vs->base.info.file_max[TGSI_FILE_IMAGE]+1);
vs->base.state.type = state->type;
vs->base.state.ir.nir = state->ir.nir;
vs->base.state.stream_output = state->stream_output; vs->base.state.stream_output = state->stream_output;
vs->base.draw = draw; vs->base.draw = draw;
vs->base.prepare = vs_llvm_prepare; vs->base.prepare = vs_llvm_prepare;