fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 03:08:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

broadcom/compiler: don't leak v3d_compile when finding a new best strategy

Browse source 
If we had selected a best strategy and find an even better one we need to
make sure we free the previous one.

Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24001>
This commit is contained in:
Iago Toral Quiroga 2023-07-05 10:38:07 +02:00 • committed by Marge Bot
parent dcc6288a13
commit be91133f87
1 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/broadcom/compiler/vir.c
View file

@ -1790,6 +1790,15 @@ skip_compile_strategy(struct v3d_compile *c, uint32_t idx)
return false;
};
}
static inline void
set_best_compile(struct v3d_compile **best, struct v3d_compile *c)
{
if (*best)
vir_compile_destroy(*best);
*best = c;
}
uint64_t *v3d_compile(const struct v3d_compiler *compiler,
struct v3d_key *key,
struct v3d_prog_data **out_prog_data,
@ -1854,11 +1863,11 @@ uint64_t *v3d_compile(const struct v3d_compiler *compiler,
if (c->spills == 0 ||
strategies[strat].min_threads == 4 ||
V3D_DBG(OPT_COMPILE_TIME)) {
best_c = c;
set_best_compile(&best_c, c);
break;
} else if (c->spills + c->fills <
best_spill_fill_count) {
best_c = c;
set_best_compile(&best_c, c);
best_spill_fill_count = c->spills + c->fills;
}
@ -1888,10 +1897,8 @@ uint64_t *v3d_compile(const struct v3d_compiler *compiler,
}
/* If the best strategy was not the last, choose that */
if (best_c && c != best_c) {
vir_compile_destroy(c);
c = best_c;
}
if (best_c && c != best_c)
set_best_compile(&c, best_c);
if (V3D_DBG(PERF) &&
c->compilation_result !=