From be8a24f3b2909a13f9b2d2bdaca0f878d1653dbc Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Thu, 28 Nov 2024 13:46:55 -0500 Subject: [PATCH] asahi: crash on fault now that we have soft fault we don't need this w/a to pass cts, and this will help us with avoiding flakes in other places. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/gallium/drivers/asahi/agx_batch.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/asahi/agx_batch.c b/src/gallium/drivers/asahi/agx_batch.c index 2070add9b43..5e61d0a2e99 100644 --- a/src/gallium/drivers/asahi/agx_batch.c +++ b/src/gallium/drivers/asahi/agx_batch.c @@ -289,14 +289,8 @@ agx_print_result(struct agx_device *dev, struct agx_context *ctx, agx_debug_fault(dev, info->address); } - /* Obscurely, we need to tolerate faults to pass the robustness parts of the - * CTS, so we can't assert that we don't fault. But it's helpful for any sort - * of debugging to crash on fault. - */ - if (dev->debug) { - assert(info->status == DRM_ASAHI_STATUS_COMPLETE || - info->status == DRM_ASAHI_STATUS_KILLED); - } + assert(info->status == DRM_ASAHI_STATUS_COMPLETE || + info->status == DRM_ASAHI_STATUS_KILLED); } static void