From bc5e77a9f2c565e23189f0d9dbf436b0781b3483 Mon Sep 17 00:00:00 2001 From: Jason Ekstrand Date: Thu, 23 Jun 2022 13:00:36 -0500 Subject: [PATCH] isl: Use util_sign_extend Reviewed-by: Alyssa Rosenzweig Reviewed-by: Kristian H. Kristensen Part-of: --- src/intel/isl/isl_format.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/intel/isl/isl_format.c b/src/intel/isl/isl_format.c index 2a7bacc4a41..bfaddf14250 100644 --- a/src/intel/isl/isl_format.c +++ b/src/intel/isl/isl_format.c @@ -1274,18 +1274,6 @@ isl_color_value_pack(const union isl_color_value *value, assert(fmtl->channels.p.bits == 0); } -/** Extend an N-bit signed integer to 32 bits */ -static inline int32_t -sign_extend(int32_t x, unsigned bits) -{ - if (bits < 32) { - unsigned shift = 32 - bits; - return (x << shift) >> shift; - } else { - return x; - } -} - static inline void unpack_channel(union isl_color_value *value, unsigned start, unsigned count, @@ -1323,7 +1311,7 @@ unpack_channel(union isl_color_value *value, } break; case ISL_SNORM: - unpacked.f32 = _mesa_snorm_to_float(sign_extend(packed, layout->bits), + unpacked.f32 = _mesa_snorm_to_float(util_sign_extend(packed, layout->bits), layout->bits); break; case ISL_SFLOAT: @@ -1338,7 +1326,7 @@ unpack_channel(union isl_color_value *value, unpacked.u32 = packed; break; case ISL_SINT: - unpacked.u32 = sign_extend(packed, layout->bits); + unpacked.u32 = util_sign_extend(packed, layout->bits); break; default: