diff --git a/.pick_status.json b/.pick_status.json index c9d9a231a05..cc18589f9db 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -2938,7 +2938,7 @@ "description": "vbo: lower VBO_SAVE_BUFFER_SIZE to avoid large VRAM usage", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null }, diff --git a/src/mesa/vbo/vbo_save.h b/src/mesa/vbo/vbo_save.h index 78a6340c196..4c73d92584c 100644 --- a/src/mesa/vbo/vbo_save.h +++ b/src/mesa/vbo/vbo_save.h @@ -111,8 +111,12 @@ _vbo_save_get_stride(const struct vbo_save_vertex_list *node) /* Default size for the buffer holding the vertices and the indices. * A bigger buffer helps reducing the number of draw calls but may * waste memory. + * 1MB was picked because a lower value reduces viewperf snx tests + * performance but larger values cause high VRAM usage (because + * larger buffers will be shared by more display lists which reduces + * the likelyhood of freeing the buffer). */ -#define VBO_SAVE_BUFFER_SIZE (20*1024*1024) +#define VBO_SAVE_BUFFER_SIZE (1024 * 1024) #define VBO_SAVE_PRIM_MODE_MASK 0x3f struct vbo_save_vertex_store {