fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-12 10:00:17 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

freedreno: replace dup() with os_dupfd_cloexec()

Browse source 
dup() will leak the new FD into any child process after fork().

Signed-off-by: Simon Ser <contact@emersion.fr>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26203>
This commit is contained in:
Simon Ser 2023-11-15 10:52:22 +01:00 • committed by Marge Bot
parent 9859283aa0
commit bbb3069d05
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/freedreno/vulkan/tu_knl_kgsl.cc
View file

@ -786,7 +786,7 @@ kgsl_syncobj_export(struct kgsl_syncobj *s, int *pFd)
if (s->fd < 0)
*pFd = -1;
else
*pFd = dup(s->fd);
*pFd = os_dupfd_cloexec(s->fd);
return VK_SUCCESS;
case KGSL_SYNCOBJ_STATE_TS:
@ -879,7 +879,7 @@ kgsl_syncobj_merge(const struct kgsl_syncobj **syncobjs, uint32_t count)
assert(ret.fd >= 0);
} else {
ret = *sync;
ret.fd = dup(ret.fd);
ret.fd = os_dupfd_cloexec(ret.fd);
assert(ret.fd >= 0);
}
break;
@ -994,7 +994,7 @@ vk_kgsl_sync_import_sync_file(struct vk_device *device,
{
struct vk_kgsl_syncobj *s = container_of(sync, struct vk_kgsl_syncobj, vk);
if (fd >= 0) {
fd = dup(fd);
fd = os_dupfd_cloexec(fd);
if (fd < 0) {
mesa_loge("vk_kgsl_sync_import_sync_file: dup failed: %s",
strerror(errno));