fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-03-04 23:20:31 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

aco: fix uninitialized data in the binary

Browse source 
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-By: Timur Kristóf <timur.kristof@gmail.com>
Fixes: 93c8ebfa78 ('aco: Initial commit of independent AMD compiler')
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3081>
This commit is contained in:
Rhys Perry 2019-09-24 17:21:51 +01:00
parent fcd6d83245
commit bbac52873f
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/amd/compiler/aco_interface.cpp
View file

@ -154,7 +154,11 @@ void aco_compile_shader(unsigned shader_count,
}
size += code.size() * sizeof(uint32_t) + sizeof(radv_shader_binary_legacy);
radv_shader_binary_legacy* legacy_binary = (radv_shader_binary_legacy*) malloc(size);
/* We need to calloc to prevent unintialized data because this will be used
* directly for the disk cache. Uninitialized data can appear because of
* padding in the struct or because legacy_binary->data can be at an offset
* from the start less than sizeof(radv_shader_binary_legacy). */
radv_shader_binary_legacy* legacy_binary = (radv_shader_binary_legacy*) calloc(size, 1);
legacy_binary->base.type = RADV_BINARY_TYPE_LEGACY;
legacy_binary->base.stage = shaders[shader_count-1]->info.stage;