fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-03-05 03:40:28 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

panfrost: Fix race condition in BO imports

Browse source 
When importing a BO, if it is already imported, then the handle will
alias an existing BO instance. It is possible for the existing owner to
free the BO after the import and leave a dangling handle before we get a
chance to increase the refcount, so we need to lock the BO table mutex
before importing, to make sure nobody else goes through the free path
during that window.

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Signed-off-by: Asahi Lina <lina@asahilina.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20403>
This commit is contained in:
Asahi Lina 2022-12-21 17:25:22 +09:00 • committed by Marge Bot
parent f401599f79
commit bb4aa8a3ea
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/panfrost/lib/pan_bo.c
View file

@ -464,10 +464,11 @@ panfrost_bo_import(struct panfrost_device *dev, int fd)
ASSERTED int ret;
unsigned gem_handle;
pthread_mutex_lock(&dev->bo_map_lock);
ret = drmPrimeFDToHandle(dev->fd, fd, &gem_handle);
assert(!ret);
pthread_mutex_lock(&dev->bo_map_lock);
bo = pan_lookup_bo(dev, gem_handle);
if (!bo->dev) {