fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-04-30 08:20:41 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

iris: Always initialize shader compilation queue ready fence

Browse source 
We use/delete this fence unconditionally, but it was initialized only
when screen->precompile is set. Move the util_queue_fence_init call
to the iris_create_uncompiled_shader to initialize it always.

Fixes: 42c34e1a ("iris: Enable threaded shader compilation")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7074
Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com>
Tested-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18182>
(cherry picked from commit 0a0aa24b33)
This commit is contained in:
Sviatoslav Peleshko 2022-08-22 13:48:40 +03:00 • committed by Dylan Baker
parent ec1d48938c
commit bb48242766
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -11965,7 +11965,7 @@
"description": "iris: Always initialize shader compilation queue ready fence",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "42c34e1ac8da3a000087c02cfd9f6fcb83e84fbc"
},

3
src/gallium/drivers/iris/iris_program.c
View file

@ -1280,8 +1280,6 @@ iris_schedule_compile(struct iris_screen *screen,
util_queue_execute_func execute)
{
util_queue_fence_init(ready_fence);
struct util_async_debug_callback async_debug;
if (dbg) {
@ -2456,6 +2454,7 @@ iris_create_uncompiled_shader(struct iris_screen *screen,
pipe_reference_init(&ish->ref, 1);
list_inithead(&ish->variants);
simple_mtx_init(&ish->lock, mtx_plain);
util_queue_fence_init(&ish->ready);
ish->uses_atomic_load_store = iris_uses_image_atomic(nir);