fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-06 19:40:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

broadcom/cle: assert attribute has a value

Browse source 
This assertions helps to fix several warnings detected by static
analyzer regarding passing null pointers to functions that expects
non-null pointer.

Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34050>
This commit is contained in:
Juan A. Suarez Romero 2025-02-03 16:24:56 +01:00 • committed by Marge Bot
parent 47f280778e
commit baa4fefe74
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/broadcom/cle/v3d_decoder.c
View file

@ -198,6 +198,7 @@ get_group_offset_count(const char **atts, uint32_t *offset, uint32_t *count,
int i;
for (i = 0; atts[i]; i += 2) {
assert(atts[i + 1]);
if (strcmp(atts[i], "count") == 0) {
*count = strtoul(atts[i + 1], &p, 0);
if (*count == 0)
@ -261,8 +262,10 @@ get_register_offset(const char **atts, uint32_t *offset)
int i;
for (i = 0; atts[i]; i += 2) {
if (strcmp(atts[i], "num") == 0)
if (strcmp(atts[i], "num") == 0) {
assert(atts[i + 1]);
*offset = strtoul(atts[i + 1], &p, 0);
}
}
return;
}
@ -313,6 +316,7 @@ create_field(struct parser_context *ctx, const char **atts)
field = xzalloc(sizeof(*field));
for (i = 0; atts[i]; i += 2) {
assert(atts[i + 1]);
if (strcmp(atts[i], "name") == 0)
field->name = xstrdup(atts[i + 1]);
else if (strcmp(atts[i], "start") == 0) {
@ -350,6 +354,7 @@ create_value(struct parser_context *ctx, const char **atts)
struct v3d_value *value = xzalloc(sizeof(*value));
for (int i = 0; atts[i]; i += 2) {
assert(atts[i + 1]);
if (strcmp(atts[i], "name") == 0)
value->name = xstrdup(atts[i + 1]);
else if (strcmp(atts[i], "value") == 0)
@ -381,8 +386,10 @@ set_group_opcode(struct v3d_group *group, const char **atts)
int i;
for (i = 0; atts[i]; i += 2) {
if (strcmp(atts[i], "code") == 0)
if (strcmp(atts[i], "code") == 0) {
assert(atts[i + 1]);
group->opcode = strtoul(atts[i + 1], &p, 0);
}
}
return;
}
@ -419,6 +426,7 @@ start_element(void *data, const char *element_name, const char **atts)
ctx->loc.line_number = XML_GetCurrentLineNumber(ctx->parser);
for (i = 0; atts[i]; i += 2) {
assert(atts[i + 1]);
if (strcmp(atts[i], "shortname") == 0)
name = atts[i + 1];
else if (strcmp(atts[i], "name") == 0 && !name)