fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 02:38:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

asahi: Hold a reference to BOs in a batch

Browse source 
Fixes GPU-side use after frees, e.g. in dEQP-GLES2.functional.texture.vertex.2d.wrap.clamp_mirror

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19215>
This commit is contained in:
Alyssa Rosenzweig 2022-10-20 22:42:39 -04:00 • committed by Marge Bot
parent 741dbadae0
commit ba551d293f
2 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/gallium/drivers/asahi/agx_pipe.c
View file

@ -567,6 +567,10 @@ agx_flush(struct pipe_context *pctx,
agxdecode_next_frame();
}
AGX_BATCH_FOREACH_BO_HANDLE(batch, handle) {
agx_bo_unreference(agx_lookup_bo(dev, handle));
}
memset(batch->bo_list.set, 0, batch->bo_list.word_count * sizeof(BITSET_WORD));
agx_pool_cleanup(&ctx->batch->pool);
agx_pool_cleanup(&ctx->batch->pipeline_pool);

6
src/gallium/drivers/asahi/agx_state.h
View file

@ -369,6 +369,12 @@ agx_batch_add_bo(struct agx_batch *batch, struct agx_bo *bo)
batch->bo_list.word_count *= 2;
}
/* The batch holds a single reference to each BO in the batch, released when
* the batch finishes execution.
*/
if (!BITSET_TEST(batch->bo_list.set, bo->handle))
agx_bo_reference(bo);
BITSET_SET(batch->bo_list.set, bo->handle);
}