fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-23 22:00:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

zink: check for error when initializing util_queue

Browse source 
When the call to util_queue_init indicates a failure, handle it by
disabling the associated feature (disk cache and thread dispatch) and
telling the user about it.

Signed-off-by: Greg Depoire--Ferrer <greg.depoire@gmail.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15071>
This commit is contained in:
Greg Depoire--Ferrer 2022-02-18 01:05:25 +01:00 • committed by Marge Bot
parent 9ed34cf9ff
commit ba2f5cb20a
1 changed files with 24 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
src/gallium/drivers/zink/zink_screen.c
View file

@ -155,7 +155,7 @@ get_video_mem(struct zink_screen *screen)
return size; return size;
} }
static void static bool
disk_cache_init(struct zink_screen *screen) disk_cache_init(struct zink_screen *screen)
{ {
#ifdef ENABLE_SHADER_CACHE #ifdef ENABLE_SHADER_CACHE
@ -163,11 +163,25 @@ disk_cache_init(struct zink_screen *screen)
snprintf(buf, sizeof(buf), "zink_%x04x", screen->info.props.vendorID); snprintf(buf, sizeof(buf), "zink_%x04x", screen->info.props.vendorID);
screen->disk_cache = disk_cache_create(buf, screen->info.props.deviceName, 0); screen->disk_cache = disk_cache_create(buf, screen->info.props.deviceName, 0);
if (screen->disk_cache) { if (!screen->disk_cache)
util_queue_init(&screen->cache_put_thread, "zcq", 8, 1, UTIL_QUEUE_INIT_RESIZE_IF_FULL, screen); return false;
util_queue_init(&screen->cache_get_thread, "zcfq", 8, 4, UTIL_QUEUE_INIT_RESIZE_IF_FULL, screen);
if (!util_queue_init(&screen->cache_put_thread, "zcq", 8, 1, UTIL_QUEUE_INIT_RESIZE_IF_FULL, screen) ||
!util_queue_init(&screen->cache_get_thread, "zcfq", 8, 4,
UTIL_QUEUE_INIT_RESIZE_IF_FULL, screen)) {
mesa_loge("zink: Failed to create disk cache queue\n");
disk_cache_destroy(screen->disk_cache);
screen->disk_cache = NULL;
util_queue_destroy(&screen->cache_put_thread);
util_queue_destroy(&screen->cache_get_thread);
return false;
} }
#endif #endif
return true;
} }
@ -2107,8 +2121,10 @@ zink_internal_create_screen(const struct pipe_screen_config *config)
goto fail; goto fail;
} }
if (screen->threaded) if (screen->threaded && !util_queue_init(&screen->flush_queue, "zfq", 8, 1, UTIL_QUEUE_INIT_RESIZE_IF_FULL, screen)) {
util_queue_init(&screen->flush_queue, "zfq", 8, 1, UTIL_QUEUE_INIT_RESIZE_IF_FULL, screen); mesa_loge("zink: Failed to create flush queue.\n");
goto fail;
}
zink_internal_setup_moltenvk(screen); zink_internal_setup_moltenvk(screen);
if (!screen->info.have_KHR_timeline_semaphore) { if (!screen->info.have_KHR_timeline_semaphore) {
@ -2191,7 +2207,8 @@ zink_internal_create_screen(const struct pipe_screen_config *config)
zink_screen_fence_init(&screen->base); zink_screen_fence_init(&screen->base);
zink_screen_init_compiler(screen); zink_screen_init_compiler(screen);
disk_cache_init(screen); if (!disk_cache_init(screen))
goto fail;
populate_format_props(screen); populate_format_props(screen);
pre_hash_descriptor_states(screen); pre_hash_descriptor_states(screen);