fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-04-26 09:00:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

radv: fix lowering VS inputs when offset >= stride on GFX6-7

Browse source 
This was supposed to be >=.

Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31209>
(cherry picked from commit ad3e6bb06a)
This commit is contained in:
Samuel Pitoiset 2024-09-17 16:25:23 +02:00 • committed by Eric Engestrom
parent 0a9bd16602
commit b9fd84e942
3 changed files with 2 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -4,7 +4,7 @@
"description": "radv: fix lowering VS inputs when offset >= stride on GFX6-7",
"nominated": true,
"nomination_type": 0,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null,
"notes": null

17
src/amd/ci/radv-tahiti-aco-fails.txt
View file

@ -1,23 +1,6 @@
# New CTS failures in 1.3.7.0
dEQP-VK.api.version_check.unavailable_entry_points,Fail
dEQP-VK.pipeline.monolithic.input_attribute_offset.vec2.offset_4.overlapping.no_memory_offset.static,Fail
dEQP-VK.pipeline.monolithic.input_attribute_offset.vec2.offset_4.overlapping.with_memory_offset.static,Fail
dEQP-VK.pipeline.monolithic.input_attribute_offset.vec2.offset_4.packed.no_memory_offset.static,Fail
dEQP-VK.pipeline.monolithic.input_attribute_offset.vec2.offset_4.packed.with_memory_offset.static,Fail
dEQP-VK.pipeline.monolithic.input_attribute_offset.vec4.offset_12.packed.no_memory_offset.static,Fail
dEQP-VK.pipeline.monolithic.input_attribute_offset.vec4.offset_12.packed.with_memory_offset.static,Fail
dEQP-VK.pipeline.monolithic.input_attribute_offset.vec4.offset_4.packed.no_memory_offset.static,Fail
dEQP-VK.pipeline.monolithic.input_attribute_offset.vec4.offset_4.packed.with_memory_offset.static,Fail
dEQP-VK.pipeline.pipeline_library.input_attribute_offset.vec2.offset_4.overlapping.no_memory_offset.static,Fail
dEQP-VK.pipeline.pipeline_library.input_attribute_offset.vec2.offset_4.overlapping.with_memory_offset.static,Fail
dEQP-VK.pipeline.pipeline_library.input_attribute_offset.vec2.offset_4.packed.no_memory_offset.static,Fail
dEQP-VK.pipeline.pipeline_library.input_attribute_offset.vec2.offset_4.packed.with_memory_offset.static,Fail
dEQP-VK.pipeline.pipeline_library.input_attribute_offset.vec4.offset_12.packed.no_memory_offset.static,Fail
dEQP-VK.pipeline.pipeline_library.input_attribute_offset.vec4.offset_12.packed.with_memory_offset.static,Fail
dEQP-VK.pipeline.pipeline_library.input_attribute_offset.vec4.offset_4.packed.no_memory_offset.static,Fail
dEQP-VK.pipeline.pipeline_library.input_attribute_offset.vec4.offset_4.packed.with_memory_offset.static,Fail
# New CTS failures in 1.3.8.0
dEQP-VK.api.get_device_proc_addr.non_enabled,Fail

2
src/amd/vulkan/nir/radv_nir_lower_vs_inputs.c
View file

@ -281,7 +281,7 @@ lower_load_vs_input(nir_builder *b, nir_intrinsic_instr *intrin, lower_vs_inputs
/* Add excess constant offset to the index. */
unsigned const_off = attrib_offset + count_format_bytes(f, 0, start);
if (attrib_stride && const_off > attrib_stride) {
if (attrib_stride && const_off >= attrib_stride) {
index = nir_iadd_imm(b, base_index, const_off / attrib_stride);
const_off %= attrib_stride;
}