From b98eb78f5865a56943146c4f523b1d9662c31b40 Mon Sep 17 00:00:00 2001
From: Vinson Lee <vlee@freedesktop.org>
Date: Tue, 6 Jun 2023 23:34:31 -0700
Subject: [PATCH] tu: Fix missing unlock

Fix defect reported by Coverity Scan.

Missing unlock (LOCK)
missing_unlock: Returning without unlocking dev->vma_mutex.

Fixes: c20139c2922 ("tu: Enable bufferDeviceAddressCaptureReplay")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23490>
(cherry picked from commit 46764815ac39dc2ea22417963d5b5be5e420bee1)
---
 .pick_status.json                      | 2 +-
 src/freedreno/vulkan/tu_knl_drm_msm.cc | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.pick_status.json b/.pick_status.json
index 5478927acb5..30d411c1593 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -8590,7 +8590,7 @@
         "description": "tu: Fix missing unlock",
         "nominated": true,
         "nomination_type": 1,
-        "resolution": 0,
+        "resolution": 1,
         "main_sha": null,
         "because_sha": "c20139c2922276238c12dc6a6cf0fbbc39e9d732"
     },
diff --git a/src/freedreno/vulkan/tu_knl_drm_msm.cc b/src/freedreno/vulkan/tu_knl_drm_msm.cc
index 8f99d60a6d6..287f65a4b91 100644
--- a/src/freedreno/vulkan/tu_knl_drm_msm.cc
+++ b/src/freedreno/vulkan/tu_knl_drm_msm.cc
@@ -267,6 +267,7 @@ tu_allocate_userspace_iova(struct tu_device *dev,
                                       size)) {
             *iova = client_iova;
          } else {
+            mtx_unlock(&dev->physical_device->vma_mutex);
             return VK_ERROR_INVALID_OPAQUE_CAPTURE_ADDRESS;
          }
       } else {