fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 16:08:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

broadcom/compiler: always clamp results from logic ops

Browse source 
We have also been clamping our integer RTs in GL for a while now.

Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
This commit is contained in:
Iago Toral Quiroga 2023-07-31 10:26:55 +02:00 • committed by Marge Bot
parent fb80e830ef
commit b95bb44c61
1 changed files with 10 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/broadcom/compiler/v3d_nir_lower_logic_ops.c
View file

@ -236,19 +236,17 @@ v3d_emit_logic_op_raw(struct v3d_compile *c, nir_builder *b,
v3d_nir_get_swizzled_channel(b, dst_chans, fmt_swz[i]);
op_res[i] = v3d_logicop(b, c->fs_key->logicop_func, src, dst);
/* In Vulkan we configure our integer RTs to clamp, so we need
* to ignore result bits that don't fit in the destination RT
* component size.
/* We configure our integer RTs to clamp, so we need to ignore
* result bits that don't fit in the destination RT component
* size.
*/
if (c->key->environment == V3D_ENVIRONMENT_VULKAN) {
uint32_t bits =
util_format_get_component_bits(
c->fs_key->color_fmt[rt].format,
UTIL_FORMAT_COLORSPACE_RGB, i);
if (bits > 0 && bits < 32) {
op_res[i] = nir_iand_imm(b, op_res[i],
(1u << bits) - 1);
}
uint32_t bits =
util_format_get_component_bits(
c->fs_key->color_fmt[rt].format,
UTIL_FORMAT_COLORSPACE_RGB, i);
if (bits > 0 && bits < 32) {
op_res[i] =
nir_iand_imm(b, op_res[i], (1u << bits) - 1);
}
}