diff --git a/.pick_status.json b/.pick_status.json index 408eb5f10be..19cd37c0294 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -1381,7 +1381,7 @@ "description": "gallium/tessellator: Fix warning suppression", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "master_sha": null, "because_sha": "790516db0bfc056df0290c42565214d4148e901a" }, diff --git a/src/gallium/auxiliary/tessellator/tessellator.cpp b/src/gallium/auxiliary/tessellator/tessellator.cpp index 7452ec6cb44..91a5390278d 100644 --- a/src/gallium/auxiliary/tessellator/tessellator.cpp +++ b/src/gallium/auxiliary/tessellator/tessellator.cpp @@ -194,9 +194,13 @@ INT32 floatToIDotF( const float& input ) { // assert( iShift < 32 ); #if defined(_MSC_VER) -#pragma warning( suppress : 4293 ) +#pragma warning( push ) +#pragma warning( disable : 4293 26452 ) #endif _fxpMaxPosValueFloat -= INT32( 1 ) << iShift; +#if defined(_MSC_VER) +#pragma warning( pop ) +#endif } // The maximum negative fixed point value is -2^(i-1). @@ -216,9 +220,13 @@ INT32 floatToIDotF( const float& input ) { // assert( iShift < 32 ); #if defined(_MSC_VER) -#pragma warning( suppress : 4293 ) +#pragma warning( push ) +#pragma warning( disable : 4293 26452 ) #endif _fxpMaxPosValueFloat -= INT32( 1 ) << iShift; +#if defined(_MSC_VER) +#pragma warning( pop ) +#endif } // The maximum negative fixed point value is 0.