fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 17:58:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

i965g: point_rast_rule comment no longer applies

Browse source 
Not sure exactly what state we want here now, will need to experiment.
This commit is contained in:
Keith Whitwell 2009-11-06 08:28:17 +00:00
parent b9bb41321a
commit b8e63e9210
1 changed files with 4 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
src/gallium/drivers/i965/brw_sf_state.c
View file

@ -221,32 +221,10 @@ sf_unit_create_from_key(struct brw_context *brw,
/* XXX: gl_rasterization_rules? something else?
*/
if (0) {
/* Rendering to an OpenGL window */
sf.sf6.point_rast_rule = BRW_RASTRULE_UPPER_RIGHT;
}
else {
/* If rendering to an FBO, the pixel coordinate system is
* inverted with respect to the normal OpenGL coordinate
* system, so BRW_RASTRULE_LOWER_RIGHT is correct.
* But this value is listed as "Reserved, but not seen as useful"
* in Intel documentation (page 212, "Point Rasterization Rule",
* section 7.4 "SF Pipeline State Summary", of document
* "Intel® 965 Express Chipset Family and Intel® G35 Express
* Chipset Graphics Controller Programmer's Reference Manual,
* Volume 2: 3D/Media", Revision 1.0b as of January 2008,
* available at
* http://intellinuxgraphics.org/documentation.html
* at the time of this writing).
*
* It does work on at least some devices, if not all;
* if devices that don't support it can be identified,
* the likely failure case is that points are rasterized
* incorrectly, which is no worse than occurs without
* the value, so we're using it here.
*/
sf.sf6.point_rast_rule = BRW_RASTRULE_LOWER_RIGHT;
}
sf.sf6.point_rast_rule = BRW_RASTRULE_UPPER_RIGHT;
sf.sf6.point_rast_rule = BRW_RASTRULE_LOWER_RIGHT;
sf.sf6.point_rast_rule = 1;
/* XXX clamp max depends on AA vs. non-AA */
/* _NEW_POINT */