From b8bb9e08bc84b07e4de99736363a18ae2106c3ce Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Mon, 11 Nov 2024 15:15:11 +0100 Subject: [PATCH] lima: add assert to validate list-lenght If this could be zero, we'd end up with divisions by zero here, which uh... would be bad? I don't think that can happen, so let's assert about this, to make it clear what's going on. CID: 1444660 Reviewed-by: Vasily Khoruzhick Part-of: --- src/gallium/drivers/lima/ir/gp/reduce_scheduler.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/lima/ir/gp/reduce_scheduler.c b/src/gallium/drivers/lima/ir/gp/reduce_scheduler.c index bcfe6fd89b0..d0d341e5054 100644 --- a/src/gallium/drivers/lima/ir/gp/reduce_scheduler.c +++ b/src/gallium/drivers/lima/ir/gp/reduce_scheduler.c @@ -54,7 +54,9 @@ static void schedule_calc_sched_info(gpir_node *node) if (node->rsched.est < est) node->rsched.est = est; - float reg_weight = 1.0f - 1.0f / list_length(&pred->succ_list); + unsigned len = list_length(&pred->succ_list); + assert(len > 0); + float reg_weight = 1.0f - 1.0f / len; if (extra_reg > reg_weight) extra_reg = reg_weight;