fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-03 18:38:11 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

mesa: add error margin to clip mask debug/check code

Browse source 
When X or Y or Z is close to W the outcome of the floating point clip
test comparision may be different between the C and x86 asm paths.
That's OK; don't report an error.

See fd.o bug 32093
This commit is contained in:
Brian Paul 2010-12-06 09:44:23 -07:00
parent 4538ce915b
commit b89a731ff2
1 changed files with 29 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
src/mesa/math/m_debug_clip.c
View file

@ -208,6 +208,24 @@ ALIGN16(static GLfloat, d[TEST_COUNT][4]);
ALIGN16(static GLfloat, r[TEST_COUNT][4]);
/**
* Check if X, Y or Z component of the coordinate is close to W, in terms
* of the clip test.
*/
static GLboolean
xyz_close_to_w(const GLfloat c[4])
{
float k = 0.0001;
return (fabs(c[0] - c[3]) < k ||
fabs(c[1] - c[3]) < k ||
fabs(c[2] - c[3]) < k ||
fabs(-c[0] - c[3]) < k ||
fabs(-c[1] - c[3]) < k ||
fabs(-c[2] - c[3]) < k);
}
static int test_cliptest_function( clip_func func, int np,
int psize, long *cycles )
{
@ -281,9 +299,18 @@ static int test_cliptest_function( clip_func func, int np,
}
for ( i = 0 ; i < TEST_COUNT ; i++ ) {
if ( dm[i] != rm[i] ) {
GLfloat *c = source->start;
STRIDE_F(c, source->stride * i);
if (psize == 4 && xyz_close_to_w(c)) {
/* The coordinate is very close to the clip plane. The clipmask
* may vary depending on code path, but that's OK.
*/
continue;
}
printf( "\n-----------------------------\n" );
printf( "(i = %i)\n", i );
printf( "dm = 0x%02x rm = 0x%02x\n", dm[i], rm[i] );
printf( "mask[%d] = 0x%02x ref mask[%d] = 0x%02x\n", i, dm[i], i,rm[i] );
printf(" coord = %f, %f, %f, %f\n",
c[0], c[1], c[2], c[3]);
return 0;
}
}